Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MorphOS] write to NULL when going to device root in filerequester #9

Closed
DorpsGek opened this issue Nov 28, 2005 · 3 comments
Closed

[MorphOS] write to NULL when going to device root in filerequester #9

DorpsGek opened this issue Nov 28, 2005 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

tokai opened the ticket and wrote:

openttd does a write to NULL when the user clicks "parent" and he reaches the device root.

Details: Under MorphOS paths looks like: volume:dir/subdir and OpenTTD is not aware of that. Since we compile using libnix (MorphOS libc) and not ixemul (alternative more unix-alike libc, but with certain limitations in 'nativiness') there is no automatical unix<->morphos path conversion and it has to be done manually. Prolly nothing problematic. :-)

Reported version: 0.4.0.1
Operating system: MorphOS

This issue was imported from FlySpray: https://bugs.openttd.org/task/9
@DorpsGek
Copy link
Member Author

Darkvater wrote:

Probably not, but can you make a patch for this since not many of us have MorhpOS lying around I think. Or change to compile with ixemul which is perhaps less work?

This comment was imported from FlySpray: https://bugs.openttd.org/task/9#comment51

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 4, 2006

tokai wrote:

Patch attached.

I tried to implement the mess with minimal # ifdef amount (a few were required still). The patch fixes the write(s) to NULL and also adds proper handling of paths (so user can change to volume root; load files from there or enter directories properly which are located there). The only thing which doesn't work is switching to a different volume, but it doesnt make much sense to add a lot of more custom MorphOS/AmigaOS code to just implement that, IMHO.

I hope it doesnt break anything. :)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/9#comment349

@DorpsGek
Copy link
Member Author

TrueBrain closed the ticket.

Reason for closing: Implemented

This comment was imported from FlySpray: https://bugs.openttd.org/task/9

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
DorpsGek pushed a commit that referenced this issue Apr 7, 2018
@TrueBrain
(svn r5492) -Backport (r5491) -Fix: [#9] MorphOS crashed when you go …
9c95e99 
…a level up on root level (tokai)
@heirecka heirecka mentioned this issue Apr 10, 2019
Closed
@andythenorth andythenorth mentioned this issue Jun 29, 2019
Closed
@auslambert auslambert mentioned this issue Sep 9, 2019
Closed
@LordAro LordAro mentioned this issue Mar 16, 2021
Closed
@FLHerne FLHerne mentioned this issue Apr 8, 2021
Closed
@LordAro LordAro mentioned this issue Jul 19, 2021
Merged
@DonaldDuck313 DonaldDuck313 mentioned this issue Sep 28, 2023
Open
@planetmaker planetmaker mentioned this issue Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek