sbr wrote:

When opening the BuildObjectWindow, the index of the selected object is passed to NWidgetMatrix::SetClicked().
However this method expect the UI index of the object, not its spec index.

Please find attached a patch against r25306.

Attachments

• fs5567-build-object-window-crash-fix-ui-object-index_r25306.patch (0.81 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5567#comment12254

frosch wrote:

The BuildObjectWindow constructor looks kind of weird.
Usually SelectOtherObject does the SetClicked stuff, but currently SelectOtherObject is called very early in the constructor and only after that the matrix is initialised, which seems to be needed after changing the selected class.
In fact the matrix->SetCount is only called in the constructor and in OnClick, but not when SelectFirstAvailableObject switches the class (which is only called via the constructor).

Would this get better, if there was a SelectOtherClass method, which would do the matrix configuration, and which would be called from SelectFirstAvailableObject, OnClick etc.?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5567#comment12257

sbr wrote:

The first patch is just bumped to r25321.
The second patch initialize the object matrix before trying to restore the selected object. SetClicked() in SelectOtherObject() when called from the constructor is now active. That eleminate the need of a second call to SetClicked() at the end of the constructor.
The third patch introduce a SelectOtherClass() method to remove duplication when a new object class is selected.
The fourth patch resize the window before setting up the object matrix to ensure SetClicked() works properly when a custom window size is restored.

Please find attached these fourth patches against r25321.

Attachments

• 00fix-use-object-ui-index-in-set-clicked_r25321.patch (0.81 KiB)
• 01change-init-object-matrix-before-setting-up-selected-object_r25321.patch (2.24 KiB)
• 02change-extract-select-other-class-method_r25321.patch (2.66 KiB)
• 03change-resize-window-before-setting-up-selected-object_r25321.patch (2.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5567#comment12276

frosch closed the ticket.

Reason for closing: Fixed

in r25538. Thanks to sbr for the patches :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5567