Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSNews.Create() may cause critical failure and crash. #5333

Closed
DorpsGek opened this issue Oct 12, 2012 · 2 comments
Closed

GSNews.Create() may cause critical failure and crash. #5333

DorpsGek opened this issue Oct 12, 2012 · 2 comments
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Aphid opened the ticket and wrote:

If a GSText object is created that holds a lot of arguments through concatenation of smaller GSText objects, and this object is then passed onto GSNews, it may crash the entire game due to an assertion failure at line 127.

The attached script is a minimal example that will cause this issue.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5333
@DorpsGek
Copy link
Member Author

Aphid wrote:

Note: Not posting the news message (just creating the string) does not cause a crash.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5333#comment11587

@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Fixed

In r24593

This comment was imported from FlySpray: https://bugs.openttd.org/task/5333

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Goal/Game script labels Apr 7, 2018
@frosch123 frosch123 added the component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) label Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DorpsGek @frosch123