FS#5156 - The ability to drag and drop to buy land....

Attached to Project: OpenTTD
Opened by Luke (luckyl) - Tuesday, 17 April 2012, 02:30 GMT
Last edited by andythenorth (andythenorth) - Monday, 14 August 2017, 20:31 GMT
Type Patch
Category Core
Status Closed
Assigned To andythenorth (andythenorth)
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 2
  • Supercheese (Supercheese) (2012-05-30)
  • Luke (luckyl) (2012-04-25)
Private No


The ability to buy land in this game is very limited, you can only buy one square at a time. It really doesn't seem so bad untill you need to prevent a town from expanding, or reserving a little something for yourself. This patch should clear a lot of this up. The first feature, is the capability of a user, or server admin to disable the users ability to buy land at all. This will make a server completely invulnerable to that stupid thing people do (aka buying land around your newly built station). No more abuse of this feature. the next feature, probably the coolest, is the ability to buy land in chunks by dragging and dropping. The limit (or none at all) can be changed from within the advanced settings. No limit is simply achieved by disabling "enable restrictive land buying." If the option is set however the limit will be determined by the next setting. The great thing, is the default for these settings will result in the land buying process we're used to today, one square at a time.

I am aware of the other patches designed for exactly this purpose. However, I assume each one will eventually become obsolete. I think we need to add this, so no one will need to reinvent this patch once over again.

Once again, the typical user will see no difference...
This task depends upon

Closed by  andythenorth (andythenorth)
Monday, 14 August 2017, 20:31 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).
Comment by Luke (luckyl) - Tuesday, 17 April 2012, 02:34 GMT
forgot to mention os tested on and revision number....
I am programming and testing the game on Ubuntu Linux 11.10 64bit
As specified by the patch title, the patch submitted was for r24122... But note, when new revisions come out, I will make sure they are compatible with my patch (and update it, if nessecary)
Comment by Ingo von Borstel (planetmaker) - Tuesday, 17 April 2012, 11:52 GMT
IMHO it does not need three settings for this purpose; a single setting which defines the amount of concurrently allowed tiles to be bought is sufficient, always allowing drag+drop. And a 2nd setting which allows the amount of tiles to be bought within a certain amount of ticks, similarily to how terraforming and bulldozing is limited. We have enough settings anyway.

virtual void OnHundredthTick() should not be needed. But changing the setting should invalidate the window types which make use of this setting.
Comment by Luke (luckyl) - Tuesday, 17 April 2012, 23:18 GMT
I think that having three options is perfectly acceptable, and straightforward. However I will work on one using your suggestions... And get back to you