Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Makefie.grf] misleading "no NFORenum/grfcodec" announcement on GRF compilation failure #4867

Closed
DorpsGek opened this issue Dec 4, 2011 · 2 comments
Closed

[Makefie.grf] misleading "no NFORenum/grfcodec" announcement on GRF compilation failure #4867

DorpsGek opened this issue Dec 4, 2011 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 4, 2011

adf88 opened the ticket and wrote:

When GRF compilation fails we get misleading "no NFORenum and GRFCodec found" message on the screen.
That's because of Makefile.grf.in line 58:

$(Q) ($(NFORENUM) --help > /dev/null 2>&1 && $(MAKE) $(OBJS_DIR)/openttd.grf && cp $(OBJS_DIR)/openttd.grf $(BIN_DIR)/openttd.grf) || ([ -e $(BIN_DIR)/openttd.grf ] && touch $(BIN_DIR)/openttd.grf && echo "no NFORenum and GRFCodec found, skipping rebuild of openttd.grf...") || (echo "no NFORenum and GRFCodec found, but no openttd.grf either. Install NFORenum and GRFCodec." && exit 1)

As we can see above, the message will be printed not only for missing NFORenum but also on "$(MAKE)" or "cp" failure.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4867
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 4, 2011

Rubidium wrote:

Well, 99% of the time it is a missing nforenum/grfcodec. Especially since this code is especially added for those that want to recompile their openttd.grf, i.e. the distros.

If it bothers you, then please give us a nicer solution as I have not been able to find one.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4867#comment10531

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 5, 2011

Rubidium closed the ticket.

Reason for closing: Fixed

In r23438.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4867

@DorpsGek DorpsGek closed this as completed Dec 5, 2011
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek