Rubidium opened the ticket and wrote:

Both ai/default/default.c and viewport.c contain code that is not used since rev. 1.

The ai code makes one tile unconditionally height 1 and unconditionally a single tile of a HQ. Making a single tile of a HQ makes no sense at all, and because the code is # if 0'ed since rev 1 I think it can be removed safely.

The viewport code is also not used since rev. 1. It furthermore does not compile when DEBUG_HILIGHT_MARKED_TILES is defined. It is furthermore inconsequent in using the extra bits -> it writes 4 bits, but only reads 1 back. The non-static functions in de # ifdef are not used anywhere in the code.

Attachments

• rip_out_useless_debug.diff (2.10 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/48