You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we open the NewGRFWindow to show GRFs associated to a network game, name of some GRFs may be unknown (""). When PACKET_UDP_SERVER_NEWGRFS packet comes with some names we didn't have, there is no update to the window, still "" is displayed.
This seems to be broken by the GRFText stuff for GRFConfig::name; now the string is cloned completely, instead of only passing the reference.
Not sure what the best way to fix this is; one way is creating GRFTexts that use pointers and GRFTexts that use buffers in themselves. The other is checking all GRFTexts whether they might need a name change, but that would involve reallocating the GRFTexts which seems somewhat non-trivial at best.
adf88 opened the ticket and wrote:
Reported version: trunk
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/4533
The text was updated successfully, but these errors were encountered: