Zuu wrote:

Here is another fix that use an idea that SmatZ had. It changes the behaviour of HandleEditBoxKey so that it will always set state to either ES_NOT_HANDLED or ES_HANDLED. This has been documented in the function documentation.

While it would now be possible to remove all initializations of the state var in simple OnKeyPress-functions, however I've made the decision to keep the initialization there and instead add it to the places where it is missing. This removes the question of how complicated should the function be in order to do a initialization of the state var even if it is not needed, just to make sure it is not forgotten if the function is changed. This simplify the documentation in the wiki as well.

Attachments

• extended_fix2.patch (2.78 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3902#comment8183

Terkhen wrote:

This bug is probably caused by the "Choose town name before its creation" feature. Since it is also present in 1.0.2, IMO the first patch is preferable to simplify backporting.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3902#comment8184

Zuu wrote:

Then I would suggest using this patch. It is solving the three places in trunk where the 'state' variable is not initialized. The fix for the AIDebug window is not needed in 1.0.2, as the edit box of the AIDebug window does only exist in trunk, but not in the 1.0 series.

I've btw. fixed the wiki so the example code there initialize the state variable.

Attachments

• fix3.patch (1.54 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3902#comment8185

Terkhen closed the ticket.

Reason for closing: Fixed

In r20139, r20140 and r20141. Thank you for the patch.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3902