Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame-per-second counter / texteff.c clean-up #34

Closed
DorpsGek opened this issue Dec 26, 2005 · 10 comments
Closed

Frame-per-second counter / texteff.c clean-up #34

DorpsGek opened this issue Dec 26, 2005 · 10 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

oteek opened the ticket and wrote:

Adds FPS counter, cleans-up texteff.c (split to texteff.c, animated_tiles.c and textmessagebox.c)
generalization of network chat messages -> textmessagebox system (used both for network chat and info window)
(infobox is enabled only for DEBUG_)

Attachments

Reported version: 0.4.0.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/34
@DorpsGek
Copy link
Member Author

matthijs wrote:

Can somebody check this on Windows and MacOS, since I don't have access to that.
Looks like a well written (and documented :-D) patch. It will probably be committed after our next release, since we will only perform the most critical fixes before the release.


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment64

@DorpsGek
Copy link
Member Author

egladil wrote:

It seems to be working on OS X. It gave some warnings about missing function declarations, so I made cocoa_v.m include textmessagebox.h which solved the problem.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment65

@DorpsGek
Copy link
Member Author

webfreakz.nl wrote:

It doesn't compile on WinXP Pro + MSVC6, see the atteched compile-log.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment77

@DorpsGek
Copy link
Member Author

oteek wrote:

fps3.diff
---------
against r3396
included textmessagebox.h in cocoa_v.m (thanks egladil)
included textmessagebox.h in win32_v.c
added few CDECLs to textmessagebox.c
updated openttd.vcproj
updated openttd.dsp
fixed typo

please test it ronald, i hope that it compiles now.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment78

@DorpsGek
Copy link
Member Author

webfreakz.nl wrote:

Still doesn't compile.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment79

@DorpsGek
Copy link
Member Author

oteek wrote:

this looks weird:
C:$gamesbllaattextmessagebox.c(1122) : error C2084: function 'void __fastcall __fastcall ChatDailyLoop(void )' already has a body
textmessagebox.c has only 608 lines, so you might have applied patch twice (or not reverted fps2.diff), try using clean svn version + fps3.diff, textmessagebox.c can't be that long.


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment80

@DorpsGek
Copy link
Member Author

webfreakz.nl wrote:

Well I did you what you said above but I thought it would not work as I reverted the patch fps(2).diff and did for both a compile, but didn't work (it showed though as green marker on the directory name which means it's a clean SVN source). But after deleting the whole directory and a new SVN-checkout + applying the patch it said:

openttd.exe - 0 error(s), 1 warning(s)


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment81

@DorpsGek
Copy link
Member Author

oteek wrote:

i believe that the warning was only this (from Build4.txt):
langswedish.txt:2703: Warning: STR_REPLACE_VEHICLES_WHITE: Param idx # 0 '' doesn't match with template command 'STRING'
which has nothing to do with this patch, so it compiles after all :)
i hope that it works too. (one part (fps counter - really useful only with fast forward) is enabled by _DEBUG and has to be enabled by 'display_info 1' in console, second (network chat) is enabled always)


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment82

@DorpsGek
Copy link
Member Author

TrueBrain wrote:

Can someone clean up this patch and give a patch that ONLY does the fps? (so without the moving and stuff)


This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment1440

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Duplicate

Of #1065.


This comment was imported from FlySpray: https://bugs.openttd.org/task/34

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) duplicate patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant