Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift clicked orders transfer and leave empty #3127

Closed
DorpsGek opened this issue Aug 16, 2009 · 4 comments
Closed

Shift clicked orders transfer and leave empty #3127

DorpsGek opened this issue Aug 16, 2009 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

niw3 opened the ticket and wrote:

This patch lets the player give "transfer and leave empty" orders while holding the SHIFT key. Without the patch shift clicked orders show a popup window with an estimated cost of $0. This feature could be extremely handy if you love to build lots of feeder vehicles distributed over lots of stations.

Attachments

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3127
@DorpsGek
Copy link
Member Author

Terkhen wrote:

I propose to add another combination: giving orders while pressing ALT creates a "unload and leave empty" order. That would complete keyboard support for all common types of orders.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3127#comment6502

@DorpsGek
Copy link
Member Author

Yexo wrote:

The main problem I have with using the shift key is that is makes shift inconsistent. Currently it's meaning is always to just test an action and get the cost. You can argue that some actions don't need testing because they are free (like adding orders), but then how to make it clear to a users which actions can be tested with shift and which not?

Besides that I don't like the changes you've done in command.cpp. As I said above, using shift for testing can probably disabled for other commands. Instead of hard coding those commands in command.cpp it's better to create a new flag in DoCommandFlag and check for that flag.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3127#comment6509

@DorpsGek
Copy link
Member Author

niw3 wrote:

I think it is clear to users that only construction, buy/sell operations, and destruction can be subject to cost estimation. I think order manipulations should not be cost estimated at all, as you say they are obviously free. If you accidentally press SHIFT (instead of CTRL) while adding orders, the GUI will give you a meaningless estimated cost. And you have to spend another click to close it.

As for the hard coding command types in command.cpp, you are absolutely right. That's a quick-dirty solution obviously.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3127#comment6510

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Won't implement

Transfers are now "leave empty" by default.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3127

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant