Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Vehicle Ordering #2689

Closed
DorpsGek opened this issue Feb 27, 2009 · 4 comments
Closed

Wrong Vehicle Ordering #2689

DorpsGek opened this issue Feb 27, 2009 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Brokkoli opened the ticket and wrote:

In the buy-window at least road veciles are ordered wrong, when ordering by capacity. Seems like only the first part of an articulated vehicle is considered.

tried with eGRVTS and trunk

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2689
@DorpsGek
Copy link
Member Author

frosch wrote:

IIRC it is this way for optimization. Neither the articulated callback nor callback 36 are called when sorting. (Applies to all sorting types)

OTOH one could compute them once, cache them, and then sort the lists.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2689#comment5685

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2009

SmatZ wrote:

Maybe similiar technique as when sorting vehicles by name can be used?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2689#comment5724

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2009

Rubidium wrote:

I think it's that way because it has been forgotten when articulated vehicles were introduced and nobody noticed it so far.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2689#comment5733

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r15666

This comment was imported from FlySpray: https://bugs.openttd.org/task/2689

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Articulated labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek