FS#2427 - Vehicle owner gets paid for whole cargo feeder share

Attached to Project: OpenTTD
Opened by Yorick (yorick) - Sunday, 23 November 2008, 14:30 GMT
Last edited by Remko Bijker (Rubidium) - Thursday, 10 December 2009, 10:52 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Very Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


If companies transfer cargo to a station that can be accessed by other companies(oil rigs, also with the infrastructure sharing patch), and someone else delivers the cargo, the one delivering the cargo will get the whole feeder share, and not the other companies. This is currently not quite common, but with IS or cargodest, it will be...

The attached patch fixes the problem, but uses a lot of memory space.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Thursday, 10 December 2009, 10:52 GMT
Reason for closing:  Won't fix
Additional comments about closing:  for now; especially because it's primarily an infrastructure sharing issue
Comment by Yorick (yorick) - Sunday, 23 November 2008, 14:32 GMT
Wrong savegame version...
Comment by Remko Bijker (Rubidium) - Monday, 24 November 2008, 10:45 GMT
This patch only replaces this problem with: last vehicle owner has to pay for delivery if his/her leg is slower than the legs before the final leg.
So the patch only makes it worse as in the current case the first legs might not get paid but in the new version the last leg might be paying a hell of a lot due to the feeder share, e.g. A moves cargo from south-east to north-west and B (accidentally) moves it back to south-east. In that case B has to pay the 'revenue' of A *and* it's running cost, whereas in the current system A only pays it's running costs which is (significantly) less than feeder share + running cost.

So the only real solution I see is disallowing transferring onto oil rigs (or other owner none stations).
Comment by Yorick (yorick) - Monday, 24 November 2008, 14:16 GMT
"So the only real solution I see is disallowing transferring onto oil rigs (or other owner none stations)." <-- what if cargotest/IS would hit the trunk?
Comment by Swallow (Swallow) - Monday, 24 November 2008, 15:50 GMT
As a possible solution, the distance each company moves the cargo could be stored. Final payment would then be divided between all companies, with each of them receiving a share proportional to the transported distance.
Comment by Remko Bijker (Rubidium) - Thursday, 10 December 2009, 10:50 GMT
An option is that upon unloading at a shared station the feedershare paid for the cargo is added to the 'balance' of the company owning the vehicle. Then once it's loaded again that feedershare is substracted from the 'balance'. This would account the different legs to the companies that made them and the final delivering company must 'just' assure that it only picks up cargo that's going to be profitable for him. This way you do not need the extra 100+ bytes in the cargopacket.