glx wrote:

I've done a similar work for signals. Maybe I should put the diff here too (for now it's on sourceforge). Just let me know.

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment20

LordOfThePigs wrote:

I think it would be a good idea to update your signals patch to the lastest SVN revision and post it here too. This way, we'll have all the things at the same place.

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment22

glx wrote:

Here it is.

Attachments

• signals.r3266.diff (28.08 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment23

LordOfThePigs wrote:

Here's an updated versions.

- Reverted changed into oldloader.c as suggested by Bjarni
- Removed the millions of asserts as suggested by Darkvater
- Removed duplicate functions and added comments
- Updated landscape.html to show the accessor function names besides the bits description (I suggest glx to do the same, it will make it easier to not code some functions twice later on)

Attachments

• map.r3272.diff (29.50 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment25

glx wrote:

I'm currently adding wrappers for rail building/removing.

I'll update landscape.html after, then I'll attach the full diff.

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment26

glx wrote:

Here's my updated version
- only 8 direct map access left in rail_cmd.c (2 should be replaced by LordOfThePigs' functions, the others needs road map accessors)
- added accessors for tunnel/bridge, and use them where appropriate (there still files where it's unapplied, and missing accessors)
- Updated landscape.html as suggested by LordOfThePigs.

Attachments

• map_accessors.r3292.diff (94.09 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment31

glx wrote:

Updated to svn r3305 (there was a conflict ;))

Attachments

• map_accessors.r3305.diff (94.04 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment34

Belugas wrote:

Here is my contribution. Far from being finished.
Mainly, i'm wrapping every house's accesses.
A lot of the code is quite strange, it takes time to get it through
WIll be upgraded as work continues.

Attachments

• map_accessors_fortownCmd.3328.diff (6.23 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment50

Belugas wrote:

Here is an update, to svn r3348.
I have included town.h as well as town_gui.c
While looking at the map branch files, I found out that Trueligh has left a real good job in commenting and simplifying processes.
It would be a pity to left it out. So, along with my modifications, I included some of his work.
The main work have been done in town_cmd.c. There are some parts left to be changed, but they are getting fewer

Attachments

• map_accessors_forTownCmdAndMore.3348.patch (14.43 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment67

glx wrote:

Just an update to r3360.

Attachments

• map_accessors.r3360.diff (94.92 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment69

egladil wrote:

This replaces the use of signals_table* in rail_cmd.c with calls to already existing (r3368) accessor functions.

Attachments

• signals2.diff (3.59 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment70

glx wrote:

I'm sorry to say that egladil, but it's already included in map_accessors.r3360.diff.

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment71

egladil wrote:

Ok. Didn't know that. I wrote this since I needed the same rewrite for my yellow signals, and then I thought I should put it somewhere so it would come to more use. So it ended up here. But then blathijs went ahead and committed it...

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment72

egladil wrote:

Also, now that i've actually read map_accessors.r3360.diff, I think you should take a look at this for a cleaner (at least I think so) way of doing ChangeSignalStates.

Attachments

• ChangeSignalStates.diff (3.06 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment73

LordOfThePigs wrote:

You are making great progress guys. I'm sorry I haven't been able to help much since my first patch. But I have more work than I can manage... So I'm afraid I won't be able to find some free time before a week or two.

This comment was imported from FlySpray: https://bugs.openttd.org/task/19#comment99

peter1138 closed the ticket.

Reason for closing: Implemented

Kind of... :-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/19