Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commandline parameter to show revision number #15

Closed
DorpsGek opened this issue Dec 4, 2005 · 5 comments
Closed

Commandline parameter to show revision number #15

DorpsGek opened this issue Dec 4, 2005 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 4, 2005

Qball opened the ticket and wrote:

a "--version" (or --revision) option would be the nicest solution, but it looks like MyGetOpt doesn't like it and '-v'/'-r' is allready in use.

I've attached a patch that appends the revition number to the help output.
Like this:

List of music drivers:
extmidi: External MIDI Driver
null: Null Music Driver

OpenTTD Revision: r3257M

I hope it aint a duplicate from sf.

Qball

Attachments

Reported version: 0.4.0.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/15
@DorpsGek
Copy link
Member Author

lucaspiller wrote:

Probably is a good idea, but it might be nicer just to say "Version: blah blah blah", i.e.:

Version: 0.4.0.1
Version: r3308

It may be a bit confusion if people see "Revision: r3308".

As for the patch, seems ok, but might be nicer with the spaces between blocks back in (see attached version).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/15#comment39

@DorpsGek
Copy link
Member Author

Qball wrote:

yes I did think about that... But shouldn't it be Version: bla bla when it's a stable release. and only telling revision when it's a svn build? is this possible?

Problem is, in my eye's, that calling it "Version: 0.4.0.1, Revision: r3308" isn't correct. It aint version 0.4.0.1, its a pre 5.0 or 4.5 or whatever the new version is going to be. But this aint a big problem. maybe call it Version: 0.4.0.1 (Developement) or whatever??

I realy would like a "--version". That is the commen way it's done. But this requires more work.


This comment was imported from FlySpray: https://bugs.openttd.org/task/15#comment40

@DorpsGek
Copy link
Member Author

Qball wrote:

I'll see if I can come up with a patch that also supports long arguments. (like f.e. --video-output).
It doesn't mind if it isnt the most fastest solution, because it's only ran once at startup.


This comment was imported from FlySpray: https://bugs.openttd.org/task/15#comment41

@DorpsGek
Copy link
Member Author

Darkvater wrote:

Aren't there default options for this? Like getopt() but with long arguments :)

Imho it should say: "Version: ". This something is either 0.4.0.1 or r4384 for example, just as what the game and network servers report.


This comment was imported from FlySpray: https://bugs.openttd.org/task/15#comment52

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2006

TrueBrain closed the ticket.

Reason for closing: Implemented

Modifieded patch added in r3379


This comment was imported from FlySpray: https://bugs.openttd.org/task/15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant