MagicBuzz wrote:

Update :
- Removed the list I added to the sation class. Replaced by an "on the fly" compute.
- Fix : A minor bug making the second vehicle separation lower than expected in some cases.

New patch made from trunk r10908

Attachments

• timetable_separation.patch (12.00 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1876

MagicBuzz wrote:

Fix : There were an issue when the vehicles where computing separation while another vehicle was waiting at the station. Now it works all the time and the separation works fine.

Attachments

• timetable_separation.patch (12.31 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1959

MagicBuzz wrote:

(sorry, lastest patch is for trunk r10977)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1960

MagicBuzz wrote:

- Fix : The bug fixed in 10977 wasn't correctly handled. Not it is completely corrected.

r01980

Attachments

• vehiculeid.patch (76.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1965

MagicBuzz wrote:

- Optimisation : Separation computation code moved from HandleLoading() to BeginLoading() function in order to save CPU. Now the separation computation is done only one time when the vehicle enters the first route station.

Still r10980

Attachments

• timetable_separation.patch (11.87 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1970

MagicBuzz wrote:

Small update : added a patch option to enable/disable the feature.

r10990

Attachments

• timetable_separation_with_option.patch (16.32 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment1987

TrueBrain wrote:

Although I am unsure this patch is really useful, for sure it fails codestyle.

- Don't include any other language than english.txt
- Use spaces to align english.txt
- Follow coding style.
- Don't do: ++index; Do: index++;
- Don't use doxygen comments inside functions
- Single line comments are: /* */. Not ///
- ... (the list is pretty long ;) Look up the wiki please)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment2595

MagicBuzz wrote:

Patch update against trunk r12032.

Fixed those small remarks.

Attachments

• timetable_separation.patch (15.52 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment3423

MagicBuzz wrote:

ignore last file.

here is the lastest r12032 patch file.

Attachments

• timetable_separation.patch (15.50 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment3426

MagicBuzz wrote:

New update. This times it should not remain any issue about comments and coding style rules

Attachments

• timetable_separation.patch (16.77 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment3429

MagicBuzz wrote:

r12059

The patch was replacing the simple function "IsSharedOrderList(const Vehicle *v)" to a Vehicle method class, but now the trunk already contains this change (r12040), so I removed the change from the patch.

Attachments

• timetable_separation.patch (13.76 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment3457

steven wrote:

Updated to r19051.

(Note that the configuration option actually will not be saved in this revision, thus loading a game will always have timetable separation enabled).

Attachments

• r19051_timetable_separation.patch (12.69 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128#comment7550

planetmaker closed the ticket.

Reason for closing: Implemented

Somewhere along the way... before r25557

This comment was imported from FlySpray: https://bugs.openttd.org/task/1128

Has this really been implemented? Quoting the request to re-open from FlySpray:

2016-12-28: A request to re-open the task has been made. Reason for request: I cannot find any evidence of auto-separation in the 1.6.1 release (r27609) so I do not understand how you can claim this feature is "Implemented". Control-clicking "Start date" is the exact opposite of auto-separation, in case that wasn't obvious.

@saveman71 I believe this is implemented in the JGR Patch Pack, but not in vanilla OpenTTD.

Autoseparation is implemented in vanilla but only with the Ctrl-clicking mechanism, saveman71 criticises. JGRPP includes a patch, that automates the mechanism via a setting.

Thanks @auge8472 it makes more sense as of why it was closed originally.

To be honest I had even missed the Ctrl+click mechanism on vanilla. Even now, I'm not sure how it works. It's a one time thing? I.e. I add more train, do I have to set it up again? It's also missing documentation on https://wiki.openttd.org/Timetable.

I'm now playing with JGR's patch and yes it's a very different approach that has been implemented.

I think (I have not played enough) that as it says "automatically adjusts the timetable", that it does manage the timetable for you, as they are different train to train and that it would automatically adjust if I were to add a train to the shared orders:

Okay I just understood @auge8472's explanation: This issue/patch is about MagicBuzz's patch, which indeed landed in vanilla.

On JGRPP's patch: https://www.tt-forums.net/viewtopic.php?f=33&t=46391

This patch was inspired by this patch from MagicBuzz but handles separation in a new way.

So it's two different things.