You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Go to "Frunpool Flughafen" (should already be centered when opening the game)
Wait a bit, it should not take long to crash
Results:
Assertion in station_map.c, Expression IsBuoy_(t)
If assertion is ignored, Assertion title < MapSize() follows, then another assertion and then it crashes.
I think this bug was not present in a somewhat older nightly.
Seems like this is a regression, this broke between r4109 and r4115.
BTW: The last assertion i get is IsTileType(t, MP_STATION) (for the "then another assertion" in the bug report itself).
Indeed, the GetStationType() screws up for the helipads. The old code says:
(str=STR_3060_AIRPORT, m5 < 0x43 || (m5 >= 83 && m5 <= 114)) ||
But the new code says:
IS_INT_INSIDE(_m[t].m5, AIRPORT_BASE, AIRPORT_BASE + AIRPORT_SIZE) ||
IS_INT_INSIDE(_m[t].m5, AIRPORT_BASE_EXTENDED, AIRPORT_BASE_EXTENDED + AIRPORT_SIZE_EXTENDED);
which is [8, 67) || [83, 114). IS_INT_INSIDE is NOT inclusive the last element os in essence it is m5>=83 && m5<114, different from the old code. Perhaps a +1 at the end? I would look at station_map.h again double-checking everything because according to the old code HANGAR0=32, HANGAR1=45, but in the new HANGAR0=32, HANGAR=65. I think that is wrong as well.
FrankW opened the ticket and wrote:
Reported version: trunk
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/86
The text was updated successfully, but these errors were encountered: