FrankW wrote:

Seems like this is a regression, this broke between r4109 and r4115.
BTW: The last assertion i get is IsTileType(t, MP_STATION) (for the "then another assertion" in the bug report itself).

This comment was imported from FlySpray: https://bugs.openttd.org/task/86#comment150

Darkvater wrote:

Indeed, the GetStationType() screws up for the helipads. The old code says:
(str=STR_3060_AIRPORT, m5 < 0x43 || (m5 >= 83 && m5 <= 114)) ||

But the new code says:
IS_INT_INSIDE(_m[t].m5, AIRPORT_BASE, AIRPORT_BASE + AIRPORT_SIZE) ||
IS_INT_INSIDE(_m[t].m5, AIRPORT_BASE_EXTENDED, AIRPORT_BASE_EXTENDED + AIRPORT_SIZE_EXTENDED);

which is [8, 67) || [83, 114). IS_INT_INSIDE is NOT inclusive the last element os in essence it is m5>=83 && m5<114, different from the old code. Perhaps a +1 at the end? I would look at station_map.h again double-checking everything because according to the old code HANGAR0=32, HANGAR1=45, but in the new HANGAR0=32, HANGAR=65. I think that is wrong as well.

This comment was imported from FlySpray: https://bugs.openttd.org/task/86#comment151

Celestar closed the ticket.

Reason for closing: Fixed

This comment was imported from FlySpray: https://bugs.openttd.org/task/86