Darkvater wrote:

That is perfectly ok, you cannot save while you are saving. The game will wait until the autosave is done, then save your game.
At least that's what it's supposed to do. Please try with the latest version, 0.4.7

This comment was imported from FlySpray: https://bugs.openttd.org/task/78#comment152

Celestar wrote:

There seem to be issues with the saveload code. Even if two autosaves happen too quickly after one another, the game freezes and doesn't wake up again.

This comment was imported from FlySpray: https://bugs.openttd.org/task/78#comment204

Darkvater wrote:

Indeed, but you have to be really quick to do this becauseI couldn't reproduce manually, only by programmatically running 2 saves right after each other.

The problem is that the flag that tells the game a save is already in progress is only called after the thread is created and running. If that takes a long time then bamm. Deadlock.

Attached diff fixes it but I don't know how beautiful it is. Comments?

Attachments

• save_deadlock.diff (0.46 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/78#comment230

TrueBrain wrote:

With some alterations I commited a patch that fixes this bug. FYI: dualcore machines always cause thread problems if you set bools within the thread. They fork the thread in the second core, and continue the game in the first core, even before 1 line is executed from the thread. Very nasty... :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/78#comment438

TrueBrain closed the ticket.

Reason for closing: Fixed

This comment was imported from FlySpray: https://bugs.openttd.org/task/78