xOR wrote:

It's an issue for me too. My admin port client sends a welcome message to players that have connected (e.g. giving him a link to the server rules). It does that after it learns about a client by the CLIENT_JOIN packet.
Ever since 1.1.4 (or r23337) it is random whether the client receives the welcome message or not, depending on its timing. More often than not there is no message received by the client. Before 1.1.4 welcome message were always received.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4990#comment10770

dihedral wrote:

to me there are two solutions to this issue:
a) allow chat to be sent to STATUS_PRE_ACTIVE clients
b) only show STATUS_ACTIVE clients in the gui, notofy the admin network only when the client is STATUS_ACTIVE, postpone execution of the on_server_connect.scr script

personally i consider a) the better option - the client is connected, has the client list of all other clients and is simply waiting for the sync to complete - chat should still be available to send and receive. The client already seems able to send chat (at least that is what i gather from the code): the server accepts chat as of STATUS_AUTHORIZED

one would have to agree on either STATUS_AUTHORIZED or STATUS_PRE_ACTIVE as of when the client may send and recieve, rather than allowing the one earlier than the other.
personally i think that should be STATUS_PRE_ACTIVE rather than STATUS_AUTHORIZED.

none the less - find patches attached.

Attachments

• chat_status_mixed.diff (0.57 KiB)
• chat_status_authorized.diff (0.56 KiB)
• chat_status_pre_active.diff (0.87 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4990#comment10892

dihedral wrote:

by the way - the patches are server side - just in case you guys want to patch your servers for the time being (if you have not done so already) ;-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4990#comment10898

Rubidium closed the ticket.

Reason for closing: Fixed

In r23957. Thanks for the patches dihedral.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4990