adf88 opened the ticket and wrote:

In the NetworkGameWindow::OnInvalidateData there is a piece of dead code that will never be called.

There is a switch on the passed data and a case label "2" but NetworkGameWindow will never be invalidated with this code. The piece of dead code does exactly the same as the NetworkAfterNewGRFScan - it updates GRF information in the network game list.

The bug probably comes from bad understanding of ~NetworkContentDownloadStatusWindow destructor. The destructor calls ScanNewGRFFiles (indirectly NetworkAfterNewGRFScan) if there are new GRF files downloaded so the network game list WILL be notified and updated. At the end the destructor calls "InvalidateWindowData(WC_NETWORK_WINDOW, 1, 2);" which is misunderstood - that invalidation is directed to NetworkContentListWindow, not any other WC_NETWORK_WINDOW.

Fixpatch attached (r22021).

Attachments

• fix_network_gui_newgrf_deadcode_r22021.diff (1.35 KiB)

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4482