Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved town placement with 2x2 and 3x3 layouts #2390

Closed
DorpsGek opened this issue Oct 29, 2008 · 3 comments
Closed

Improved town placement with 2x2 and 3x3 layouts #2390

DorpsGek opened this issue Oct 29, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

cirdan opened the ticket and wrote:

I would like to submit the attached patch for inclusion in trunk. It improves town placement during map generation if the selected town layout is either 2x2 or 3x3, so that towns are placed in such a way that they "meet nicely", ie, roads from neighbouring towns line up properly.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2390
@DorpsGek
Copy link
Member Author

PhilSophus wrote:

Nice patch. A few little coding styles issues I discovered, though:
- The second line of the TL_2X2_GRID case has an alignment issue (use tabs for indent, spaces for alignment).
- The opening parenthesis should go directly after the function names (no space)
- On the other hand, there should be spaces between operators to make the code more readable
- The default case should be "default: break;" (At least that is what similar places do, and it doesn't look so strange).

I hope, with those issues "fixed" the patch will go to trunk soon

This comment was imported from FlySpray: https://bugs.openttd.org/task/2390#comment5116

@DorpsGek
Copy link
Member Author

cirdan wrote:

Thanks for your suggestions. I more or less ignored the coding style--I don't pay much attention to it in the early stages of a patch, leaving it as something to be done later. But the patch is already some weeks old and it seems to "just work", ie, no bugs so far (it's rather trivial anyway), so perhaps it's time for polishing (and you've saved me the work of finding the actual nonconformances :-) ).

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2390#comment5120

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2009

Rubidium closed the ticket.

Reason for closing: Implemented

In r14821.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2390

@DorpsGek DorpsGek closed this as completed Jan 4, 2009
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek