FS#1640 - Sorting in replace dialog

Attached to Project: OpenTTD
Opened by Fragster (Fragster) - Thursday, 10 January 2008, 16:09 GMT
Last edited by Alberth (Alberth) - Sunday, 07 September 2014, 16:23 GMT
Type Feature Request
Category Interface
Status Closed
Assigned To Nick Malishchak (ChubbyPitbull)
Operating System All
Severity Medium
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


SUBJ like in «new vehicle» window

The user actually would like to see the sorting that is implemented in the Replace Dialog been added to the New Vehicle Dialog.
This task depends upon

Closed by  Alberth (Alberth)
Sunday, 07 September 2014, 16:23 GMT
Reason for closing:  Implemented
Additional comments about closing:  in r26800, without cargo filter
Comment by Nick Malishchak (ChubbyPitbull) - Monday, 19 August 2013, 01:14 GMT
Ported sorting code from build_vehicle_gui to autoreplace_gui. Allows sorting by the various engine sort types. Cargo sorting is done automatically based on cargo type, same as default behavior. Can port cargo sorting as well if that feature is requested.
Comment by Nick Malishchak (ChubbyPitbull) - Monday, 19 August 2013, 02:21 GMT
This patch includes the previous patch plus the ported manual cargo sorting code from the build_vehicle_gui.

EDIT: Fixed a coding-guidelines comment spacing issue I missed in the ReplaceVehicleWindow class definition parameters. I can't seem to delete the original patch, please use the -2 version.
Comment by Nick Malishchak (ChubbyPitbull) - Monday, 19 August 2013, 13:43 GMT
Something I noticed while testing, the Cargo/Engine sorting I ported over is happening on top of the default-auto sorting for Replace Vehicles, which I believe filters out vehicles that do not match a cargo type of the vehicle to be replaced. Should the original auto-sorting method for Replace Vehicles be disabled?
Comment by frosch (frosch) - Friday, 23 August 2013, 17:38 GMT
You cannot autoreplace vehicles which vehicles which cannot carry the same cargo. So, since the server would reject such autoreplace settings anyway, it makes no sense to display them in the GUI in the first place. (if that's what you were asking)