ChubbyPitbull wrote:

Ported sorting code from build_vehicle_gui to autoreplace_gui. Allows sorting by the various engine sort types. Cargo sorting is done automatically based on cargo type, same as default behavior. Can port cargo sorting as well if that feature is requested.

Attachments

• FS1640-proposed.patch (23.69 KiB)
• proposedReplaceUI.PNG (67.55 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12543

ChubbyPitbull wrote:

This patch includes the previous patch plus the ported manual cargo sorting code from the build_vehicle_gui.

EDIT: Fixed a coding-guidelines comment spacing issue I missed in the ReplaceVehicleWindow class definition parameters. I can't seem to delete the original patch, please use the -2 version.

Attachments

• FS1640-proposed-withManualCargoSorting.patch (27.71 KiB)
• proposedReplaceUI-withManualCargo.PNG (48.45 KiB)
• FS1640-proposed-withManualCargoSorting-2.patch (28.99 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12544

ChubbyPitbull wrote:

Something I noticed while testing, the Cargo/Engine sorting I ported over is happening on top of the default-auto sorting for Replace Vehicles, which I believe filters out vehicles that do not match a cargo type of the vehicle to be replaced. Should the original auto-sorting method for Replace Vehicles be disabled?

This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12545

frosch wrote:

You cannot autoreplace vehicles which vehicles which cannot carry the same cargo. So, since the server would reject such autoreplace settings anyway, it makes no sense to display them in the GUI in the first place. (if that's what you were asking)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12560

Alberth closed the ticket.

Reason for closing: Implemented

in r26800, without cargo filter

This comment was imported from FlySpray: https://bugs.openttd.org/task/1640