Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting in replace dialog #1640

Closed
DorpsGek opened this issue Jan 10, 2008 · 5 comments
Closed

Sorting in replace dialog #1640

DorpsGek opened this issue Jan 10, 2008 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Fragster opened the ticket and wrote:

SUBJ like in «new vehicle» window

EDIT:
The user actually would like to see the sorting that is implemented in the Replace Dialog been added to the New Vehicle Dialog.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1640
@DorpsGek
Copy link
Member Author

ChubbyPitbull wrote:

Ported sorting code from build_vehicle_gui to autoreplace_gui. Allows sorting by the various engine sort types. Cargo sorting is done automatically based on cargo type, same as default behavior. Can port cargo sorting as well if that feature is requested.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12543

@DorpsGek
Copy link
Member Author

ChubbyPitbull wrote:

This patch includes the previous patch plus the ported manual cargo sorting code from the build_vehicle_gui.

EDIT: Fixed a coding-guidelines comment spacing issue I missed in the ReplaceVehicleWindow class definition parameters. I can't seem to delete the original patch, please use the -2 version.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12544

@DorpsGek
Copy link
Member Author

ChubbyPitbull wrote:

Something I noticed while testing, the Cargo/Engine sorting I ported over is happening on top of the default-auto sorting for Replace Vehicles, which I believe filters out vehicles that do not match a cargo type of the vehicle to be replaced. Should the original auto-sorting method for Replace Vehicles be disabled?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12545

@DorpsGek
Copy link
Member Author

frosch wrote:

You cannot autoreplace vehicles which vehicles which cannot carry the same cargo. So, since the server would reject such autoreplace settings anyway, it makes no sense to display them in the GUI in the first place. (if that's what you were asking)


This comment was imported from FlySpray: https://bugs.openttd.org/task/1640#comment12560

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2014

Alberth closed the ticket.

Reason for closing: Implemented

in r26800, without cargo filter


This comment was imported from FlySpray: https://bugs.openttd.org/task/1640

@DorpsGek DorpsGek closed this as completed Sep 7, 2014
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant