Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more windows than 22 at once #925

Closed
DorpsGek opened this issue Jun 23, 2007 · 4 comments
Closed

Allow more windows than 22 at once #925

DorpsGek opened this issue Jun 23, 2007 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

bilbo opened the ticket and wrote:

Only 25 windows are allowed at once (and 3 of them taken by toolbars etc, leaving only 22 available windows).
Since 1600x1200 screen can usefully accomodate more windows than that and some multiheaded configurations even more and
incoming newspaper tend to delete usually the most important ones (murphys laws :) it may be nice to increase this amount, optimally to unlimited number.

I have made a patch that will raise the number to 60 (giving 57 usable windows) which should be sufficient for most players and is close to maximum (63) that could be achieved without some "more significant" rewrite (i.e. more than 15 lines of code) of windowing system (maybe someone will do that later ... not me, since 57 windows is enough for me :).

Tried creating about 55 vehicles, each with its window and running them all at once.... it worked fine.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/925
@DorpsGek
Copy link
Member Author

TrueBrain wrote:

Nice idea, but I wonder if we can make it dynamic (in other words: no limit anymore what so ever).


This comment was imported from FlySpray: https://bugs.openttd.org/task/925#comment1433

@DorpsGek
Copy link
Member Author

bilbo wrote:

Maybe, the limit that is now causing problems is _active_viewports (in viewport.cpp) - it is bitmasked variable and since 1 window need one viewport, this is the one that is currently limiting it. Now it is int64 (64 bits), expanding the limit more will require to somehow redo the viewport things (and since windows and viewport are now in static array, it will be necessary to make them dynamic and alloc/realloc them or convert to linked list ...)

Not so easy to make it really unlimited, some things will need to be slightly rewritten. This is just a quick fix, but increasing limit of usable windows from 22 to 57 will do for most people for now (till someone really rewrite it to allow unlimited windows)


This comment was imported from FlySpray: https://bugs.openttd.org/task/925#comment1434

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 1, 2007

bilbo wrote:

As belugas is going to raise the window limit by other means (to "unlimited" :) I suggest this task gets closed, as the patch will soon be obsolete.

See http://www.tt-forums.net/viewtopic.php?f=33&t=35090 for belugas post.


This comment was imported from FlySpray: https://bugs.openttd.org/task/925#comment2839

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Out of date

Your memory's the limit


This comment was imported from FlySpray: https://bugs.openttd.org/task/925

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant