Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stations: extended byte for NewStation ID #6562

Closed
DorpsGek opened this issue May 17, 2017 · 3 comments
Closed

Stations: extended byte for NewStation ID #6562

DorpsGek opened this issue May 17, 2017 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues

Comments

@DorpsGek
Copy link
Member

kiwitree opened the ticket and wrote:

This patch makes NUM_STATIONS_PER_GRF to 65535.
It's using grf version 9 and savegame version 197.

NewGRF syntax changes
NewStation ID: byte to extended byte
Action 4: Not using C4xx and C5xx range. It uses feature 0x04 and extended byte id for name of stations and it uses feature 0x48 and D0xx range for class id.
Action 0: Added Property 0x1B. It sets text id for station class.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6562
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth wrote:

"Nobody needs 65535 stations". But I left it open because frosch indicates that increasing newgrf limits is a valid OpenTTD goal :)

Changed status to reflect the attached patch.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6562#comment14699

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@frosch123 frosch123 added component: NewGRF This issue is related to NewGRFs and removed NewStations labels Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Eddi suggests this is useful for grfv9.

Is anyone prepared to maintain a grv9 branch? This could then be committed to it.

@andythenorth andythenorth removed the stale Stale issues label Jan 7, 2019
@stale
Copy link

stale bot commented Mar 29, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 29, 2019
@stale stale bot closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants