FS#6548 - Buoys can prevent oil rig spawns

Attached to Project: OpenTTD
Opened by Ricardo (Samu) - Saturday, 25 March 2017, 12:35 GMT
Type Bug
Category Core
Status New
Assigned To No-one
Operating System All
Severity Very Low
Priority Normal
Reported Version 1.7.0-RC1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


When an oil rig is spawning, the special water check require that the tile is of type water. Ship Depots and Locks are tiles of type water and won't prevent oil rig from spawning. Buoys, however, are of tile type station, and are preventing oil rigs from spawning.

This patch should allow it to spawn when checking for water nearby on buoys as well.
This task depends upon

Comment by Ricardo (Samu) - Saturday, 25 March 2017, 13:29 GMT
My bad, made a bool mistake, this patch should do what I was intending.

EDIT: now with parentesis. Use v3.
Comment by Peter Nelson (peter1138) - Saturday, 01 April 2017, 06:20 GMT
Arguably the check should be extended the other way so that depots and locks are excluded?
Comment by Peter Nelson (peter1138) - Monday, 03 April 2017, 12:22 GMT
Ok, so now depots and locks aren't considered clear... does it make sense that buoys should be? I think probably not.
Comment by andythenorth (andythenorth) - Wednesday, 23 August 2017, 07:34 GMT
If we're changing this, I would consider depots and locks not clear. Also buoys not clear.