Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raising/lowering 'Maximum no. competitors' setting in multiplayer #6438

Closed
DorpsGek opened this issue Apr 5, 2016 · 4 comments
Closed

raising/lowering 'Maximum no. competitors' setting in multiplayer #6438

DorpsGek opened this issue Apr 5, 2016 · 4 comments
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 5, 2016

Samu opened the ticket and wrote:

The bug happens when the AI/Game script Configuration window is brought up this way:

1 - Launch OpenTTD
2 - Click multiplayer
3 - Start server
4 - Click new game
5 - Click Options > AI/Game script Configuration

Bugs:
- if the value is 14: when clicking '<' to lower it to 13, the '>' can't be clicked to raise it to 14, unless lowered to 12
- if the value is 13: when clicking '>' to raise it to 14, the '>' can be clicked, but it shouldn't. Clicking it fixes itself
- if the value is 0: when clicking '>' to raise it to 1, the '<' can't be clicked to lower it to 0, unless raised to 2
- if the value is 1: when clicking '<' to lower it to 0, the '<' can be clicked, but it shouldn't. Clicking it fixes itself

Reported version: 1.6.0
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/6438
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 4, 2018

Samu wrote:

you sure? I just reproduced it in 1.7.2

This comment was imported from FlySpray: https://bugs.openttd.org/task/6438#comment14844

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 4, 2018

Samu wrote:

proof

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6438#comment14845

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 4, 2018

Wolf01 wrote:

Reopened: reproduced in r27967

This comment was imported from FlySpray: https://bugs.openttd.org/task/6438#comment14846

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
@GabdaZM
Copy link
Contributor

GabdaZM commented Jan 1, 2019

I found that when you click on the '<' or '>' buttons to change the number of the competitors, the value won't get updated on the client, but sent to the server. The server registers the update and sends the new number back to the client, but it only updates the text on the screen, but it won't call a button invalidations, so only a part of the window gets updated. (If you click on other functioning parts of the window, the arrow button validation will be updated.)
While it would be easy to store the modification of the number on the client as well, I think it would only be a workaround, as in case another client modifies this number while this window is open in our client as well (and the number gets 0 or 14) only the number will be updated and not the button invalidation.

GabdaZM added a commit to GabdaZM/OpenTTD that referenced this issue Jan 15, 2019
@GabdaZM
Fix OpenTTD#6438: Button disable fix in AI/Game Script Configuration …
5663c25 
…window

Disabling/enabling of the decrease/increase button in accordance with the
max no. competitors value was not working properly in multiplayer mode.
@SamuXarick SamuXarick mentioned this issue Jan 23, 2019
Closed
GabdaZM added a commit to GabdaZM/OpenTTD that referenced this issue Jan 27, 2019
@GabdaZM
Fix OpenTTD#6438: Button disable fix in AI/Game Script Configuration …
8bc875d 
…window

Disabling/enabling of the decrease/increase button in accordance with the
max no. competitors value was not working properly in multiplayer mode.
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 1, 2019
@PeterN
Fix OpenTTD#6438: Properly invalidate AI Settings window when max no …
038a6d0 
…competitor setting is changed.
@PeterN PeterN closed this as completed in 0355f88 Feb 1, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@PeterN @nielsmh
Fix OpenTTD#6438: Properly invalidate AI Settings window when max no …
439a8ae 
…competitor setting is changed.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@PeterN @douiwby
Fix OpenTTD#6438: Properly invalidate AI Settings window when max no …
60240b6 
…competitor setting is changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrueBrain @DorpsGek @GabdaZM