Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depress sell button when hovered with vehicle on depot GUI #6390

Closed
DorpsGek opened this issue Nov 14, 2015 · 4 comments
Closed

Depress sell button when hovered with vehicle on depot GUI #6390

DorpsGek opened this issue Nov 14, 2015 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Eearslya opened the ticket and wrote:

Simple and straightforward, lowers the sell button when a vehicle is dragged onto it, for better UI feedback.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6390
@DorpsGek
Copy link
Member Author

Eearslya wrote:

Small improvement, merges the two if statements into one. (Thanks, frosch.)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6390#comment14085

@DorpsGek
Copy link
Member Author

frosch wrote:

Something is missing that makes it notice when the dragging is aborted.
Currently the button remains lowered, when pressing ESC while hovering.

Maybe OnPlaceObjectAbort ?

This comment was imported from FlySpray: https://bugs.openttd.org/task/6390#comment14087

@DorpsGek
Copy link
Member Author

Eearslya wrote:

Yep, you're exactly right. Fixed.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6390#comment14088

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r27446

This comment was imported from FlySpray: https://bugs.openttd.org/task/6390

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek