FS#6284 - UpdateStationSignCoord call after station building/joining

Attached to Project: OpenTTD
Opened by M.Czapkiewicz (McZapkie) - Friday, 17 April 2015, 23:02 GMT
Last edited by andythenorth (andythenorth) - Saturday, 19 August 2017, 09:37 GMT
Type Feature Request
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Medium
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Function UpdateStationSignCoord in station_cmd.cpp is called only during deleting station parts.
I propose to call it also during station building or joining parts to the existing station.
Currently station labels sign remains in original location, such behaviour is often abused (so called station sign fraud)
to achieve payment from large distance between sign, whereas real vehicle travel is one magnitude smaller.
This task depends upon

Closed by  andythenorth (andythenorth)
Saturday, 19 August 2017, 09:37 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Flyspray clean up: addressing potential exploits in MP is not a current OpenTTD goal. I'm not commenting on validity of behaviour or not, but I suspect there are 'many sides' to this. Either way, it's not a thing that will currently be changed, so closing. Thanks for the suggestion :)
Comment by dP (_dp_) - Wednesday, 29 April 2015, 19:18 GMT
Station sign position plays an important role in game mechanics, especially on some servers. Having it move unfavourably can really mess up the whole game sometimes. Also this is the first time I hear of it being considered an abuse, on novapolis and btpro you can place sign wherever you want.
Comment by Coragem (ST2) - Thursday, 30 April 2015, 21:07 GMT
Actually I agree with McZapkie. station signs should appear in a place where's a part of the station exists. And that, as told, was considered an illegal station spread, accordingly BTPro rules (confirmed by 2 admins), that work as a complement to Multiplayer OpenTTD rules. Afterall, required some "juggling" to get the final station. Anyway, it's my opinion and stations are fixed when spoted (with admin intervention, most of the cases)
(edit: typo)
Comment by M.Czapkiewicz (McZapkie) - Saturday, 02 May 2015, 11:06 GMT
dP, your arguing is not quite valid, because station sign already can be moved, just in case of deletion part of the station.
My proposal is to provide symmetry - move station sign also in case of adding part of the station.
It is fair from two reasons: station sign would be well defined for a given station layout, regardless of building method (dragging left to right, right to left, adding, deleting etc.), secondly it would suppress using station label exploit, see attached image for example.
Comment by dP (_dp_) - Friday, 08 May 2015, 18:41 GMT
What you are talking about is called spreading and has nothing to do with station sign. There is already game settings to prevent distant joins and only moderators can rule out those who works around it.
Besides what kind of logic do you expect the game to follow in this case? There is no way at the time of station construction to know which part of it is going to be used.
And just calling UpdateStationSignCoord as you suggested won't do a thing in case of station expansion because it just clamps sign tile to station bounding box.