FS#6263 - Business limit is way too low

Attached to Project: OpenTTD
Opened by Nickr (mijnnickr) - Monday, 23 March 2015, 06:44 GMT
Last edited by andythenorth (andythenorth) - Saturday, 12 August 2017, 16:47 GMT
Type Feature Request
Category Core
Status Closed
Assigned To andythenorth (andythenorth)
Operating System All
Severity Critical
Priority Normal
Reported Version 1.5.0-RC1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Businesses are limited to only 15 per server. This limits the game by so much that I doubt people bother to play multiplayer properly. If you are in a popular server, like the Reddit server, where pretty much all the players are, your business gets destroyed with all of its property after only 4 in real hours. What's the point in advancing then? After you woke up you already lost all of your goods.

Now I could join a less populated server, however it's called multiplayer. If there are less people what's the point in not playing single-player, where your businesses stay no matter what?

The reason this is critical is because multiplayer is so broken with a "lot" of players. It doesn't allow progress and it has no point at all this way. I would recommend this to my friends but after seeing that your business gets destroyed after you basically sleep, then there's really no point.

If you could raise the limit from 15 to at least 50, that would be great.
This task depends upon

Closed by  andythenorth (andythenorth)
Saturday, 12 August 2017, 16:47 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Changing MAX_COMPANIES is not a goal currently.
Comment by Nickr (mijnnickr) - Monday, 23 March 2015, 06:55 GMT
Just read through the code a bit. It's literally increasing MAX_COMPANIES......... I would love you if you could increase it, as I'm unsure where the actual definition is.
Comment by Nickr (mijnnickr) - Monday, 23 March 2015, 17:20 GMT
Read a bit through it. It does require more colors, however I'm unsure how to add these. I'm not sure what other limitations there are. I just hope you somehow increase the company limit, it would be great.

Do notice that even if it's hard, it's not impossible and it should really be added.
Comment by FLHerne (flherne) - Saturday, 28 March 2015, 18:14 GMT
It isn't just increasing MAX_COMPANIES - 16 companies (including not-a-company) is the maximum you can fit in four bits. While I haven't checked, the company ID is almost certainly stored as such for multiplayer and in savegames.

Reddit Server 1 hits the limit sometimes, no other server does so very often. In any case, filling the map up with abandoned companies would both cause lag and make it harder for new players to start, so autocleaning would be needed regardless.

A feature limitation that moderately affects one server isn't 'critical' by any means, please be sensible when picking severity.
Comment by Ingo von Borstel (planetmaker) - Thursday, 02 April 2015, 22:44 GMT
The auto-cleaning time is a user (or rather server-)configurable setting. It's up to the server owner to choose how long it takes before a company is deleted, they can also choose to never delete automatically a company.

MAX_COMPANIES defines how many companies are supported - but the limit of 15 companies is not required by that constant itself - it is only expression of the limits. Rather it's found throughout many parts of the game which rely on 4 bits to store the ownership information, both on the map as well as in all the commands passed in OpenTTD's internal messaging system - thus in effect you'll have to thoroughly refactor the latter and basically touch every function which can change the game state; unique colours for the different companies is the least of the problems you'll encounter. Such change surely is doable - but certainly not a small task. And certainly not critical ;)