Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while loading savegame from 1.4 in 1.5 #6197

Closed
DorpsGek opened this issue Dec 30, 2014 · 9 comments
Closed

Crash while loading savegame from 1.4 in 1.5 #6197

DorpsGek opened this issue Dec 30, 2014 · 9 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues

Comments

@DorpsGek
Copy link
Member

KTG opened the ticket and wrote:

Hello,
Tried to load this old save game made with either 1.4.3 or 1.4.4. I've played this particular map since 2 years now (ever since I found it in very advanced state on the forums).
I would upload it, but its size is over the allowed limit. Any pointers as to how to do it differently would be welcome.

Attachments

Reported version: 1.5.0-beta1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6197
@DorpsGek
Copy link
Member Author

KTG wrote:

Forgot to select: Version is 1.5.0-beta1. Computer is Win7 on x64.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13668

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 30, 2014

hackalittlebit wrote:

KTG Please send savegame.
That makes it more easy to debug.

@Frosch: See #6196
I suspect that something with waterclass is not reset correctly when loading old savegames.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13669

@DorpsGek
Copy link
Member Author

KTG wrote:

As written: "I would upload it, but its size is over the allowed limit. Any pointers as to how to do it differently would be welcome."

So, where should I send it?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13670

@DorpsGek
Copy link
Member Author

hackalittlebit wrote:

Send email to Rubidium and explain for a second why.
e.g. that it belongs to '#6197 - Crash upon loading save game'
From there on it will find its way.
rubidium@openttd.org


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13671

@DorpsGek
Copy link
Member Author

Alberth wrote:

The general info@openttd.org address is much better than addressing an individual developer


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13674

@DorpsGek
Copy link
Member Author

Rubidium wrote:

FAULTING_IP:
openttd!AfterLoadLinkGraphs+aa [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\linkgraph_sl.cpp @ 236]
00000001`3fc36b76 8b410c mov eax,dword ptr [rcx+0Ch]

EXCEPTION_RECORD: ffffffffffffffff -- (.exr 0xffffffffffffffff)
.exr 0xffffffffffffffff
ExceptionAddress: 000000013fc36b76 (openttd!AfterLoadLinkGraphs+0x00000000000000aa)
ExceptionCode: c0000005 (Access violation)
ExceptionFlags: 00000000
NumberParameters: 2
Parameter[0]: 0000000000000000
Parameter[1]: 000000000000000c
Attempt to read from address 000000000000000c

PROCESS_NAME: openttd.exe

ADDITIONAL_DEBUG_TEXT:
Use '!findthebuild' command to search for the target build information.
If the build information is available, run '!findthebuild -s ; .reload' to set symbol path and load symbols.

MODULE_NAME: openttd

FAULTING_MODULE: 0000000076e50000 ntdll

DEBUG_FLR_IMAGE_TIMESTAMP: 549b1bbe

ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at "0x%08lx" referenced memory at "0x%08lx". The memory could not be "%s".

EXCEPTION_CODE: (NTSTATUS) 0xc0000005 - The instruction at "0x%08lx" referenced memory at "0x%08lx". The memory could not be "%s".

EXCEPTION_PARAMETER1: 0000000000000000

EXCEPTION_PARAMETER2: 000000000000000c

READ_ADDRESS: 000000000000000c

FOLLOWUP_IP:
openttd!AfterLoadLinkGraphs+aa [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\linkgraph_sl.cpp @ 236]
00000001`3fc36b76 8b410c mov eax,dword ptr [rcx+0Ch]

MOD_LIST:

FAULTING_THREAD: 0000000000002724

BUGCHECK_STR: APPLICATION_FAULT_NULL_CLASS_PTR_DEREFERENCE_NULL_POINTER_READ_INVALID_POINTER_READ_WRONG_SYMBOLS

PRIMARY_PROBLEM_CLASS: NULL_CLASS_PTR_DEREFERENCE

DEFAULT_BUCKET_ID: NULL_CLASS_PTR_DEREFERENCE

LAST_CONTROL_TRANSFER: from 000000013fc3078c to 000000013fc36b76

STACK_TEXT:
00000000`001eca20 00000001`3fc3078c : 00000000`00000071 00000000`001ecab9 00000000`000000a1 00000000`00000000 : openttd!AfterLoadLinkGraphs+0xaa [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\linkgraph_sl.cpp @ 236]
00000000`001eca50 00000001`3fc4180f : 00000000`00000000 00000000`00400000 00000000`00000000 00000001`407829e0 : openttd!AfterLoadGame+0xbcc4 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\afterload.cpp @ 2988]
00000000`001ecb20 00000001`3fc4254d : 0000bc00`5854544f 00000001`4075d680 00000000`001ee4d0 00000000`00000000 : openttd!DoLoad+0x2d7 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\saveload.cpp @ 2741]
00000000`001ecba0 00000001`3fab413b : 00000000`00000001 00000004`00000000 00000000`00000000 00000001`3facfa01 : openttd!SaveOrLoad+0xce9 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\saveload\saveload.cpp @ 2838]
00000000`001ee3a0 00000001`3fab4657 : 00000000`00000004 00000000`00000000 00000000`00000000 00000000`000000c5 : openttd!SafeLoad+0x5f [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\openttd.cpp @ 1007]
00000000`001ee3d0 00000001`3fab5d9a : 00000000`1d025c00 00000000`002b0904 00000000`1d025c1c 00000000`001eee88 : openttd!SwitchToMode+0x4ab [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\openttd.cpp @ 1096]
00000000`001eee00 00000001`3fd50099 : 00000000`1d025c1c 00000000`001ef000 00000000`1d025c0c 00000000`1d025c0c : openttd!GameLoop+0x6a [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\openttd.cpp @ 1455]
00000000`001eef10 00000001`3fab3b1a : 00000000`00000000 00000000`001ef0a0 00000000`00000000 00000000`00000000 : openttd!VideoDriver_Win32::MainLoop+0x3c5 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\video\win32_v.cpp @ 1292]
00000000`001eefa0 00000001`3fd52751 : 00000000`00000000 00000000`001ef2d0 00000000`00000001 00000000`00000000 : openttd!openttd_main+0xeea [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\openttd.cpp @ 865]
00000000`001ef2b0 00000001`3fe3e8b4 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : openttd!WinMain+0x141 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\os\windows\win32.cpp @ 457]
00000000`001ef9b0 00000000`76d459ed : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : openttd!__tmainCRTStartup+0x154 [f:\dd\vctools\crt_bld\self_64_amd64\crt\src\crt0.c @ 275]
00000000`001efa60 00000000`00000000 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : kernel32+0x159ed

lg is valid pointer
node_id is 0
station_id is 982 (which resolves to an invalid pointer, i.e. station 982 does not exist).


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13676

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2015

planetmaker wrote:

Savegame: https://devs.openttd.org/~planetmaker/patches/fs6196.sav (yes, wrong savegame name due to wrong desgination in e-mail)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment13697

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Reproduced - crashes for me in 1.7.1 with the savegame provided in planetmaker's comment.

Task is only assigned to me so I could mark it 'confirmed'. FS has no way for me to unassign myself. It's great eh? :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6197#comment14519

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Cargodist labels Apr 7, 2018
@TrueBrain TrueBrain added needs triage This issue needs further investigation before it becomes actionable bug Something isn't working and removed bug from FlySpray labels Apr 12, 2018
@TrueBrain TrueBrain changed the title Crash: loading savegame Crash while loading savegame from 1.4 in 1.5 Apr 12, 2018
@andythenorth andythenorth added stale Stale issues and removed Cargodist labels Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants