Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning trains through number - Display list companies trains , train length tile #6181

Closed
DorpsGek opened this issue Dec 4, 2014 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 4, 2014

marek17 opened the ticket and wrote:

I have one locomotive and 7 wagons, I need the whole kit train clone 40 times. It is my job and still uncomfortably click "clone train". Can anything be done through a number I enter, with this number I clone 40 new locomotive with wagons.

For all locomotives not visible length of the full set.
(manage list)
I have the inclination, therefore, 40 new locomotives, which are located in the non-inclusion of trains. I'm too busy, every train manually moved to the new group. I would check all newly created trains (as in download newgrf) and edit the list would be the possibility of transferring trains to the desired group.

Attachments

Reported version: 1.4.4
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6181
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 5, 2014

frosch wrote:

Some hints I am not sure you know about:
- You can also clone vehicles via the vehicle window instead of via the depot window, when the vehicle is inside a depot. That saves mouse movement.
- Use Ctrl+Click on the clone to share orders. This will also prevent a vehicle window being opened for the new vehicle.
- Cloning also copies the group.
- Ctrl+Drag in the group window moves all vehicles sharing orders.

More about shared orders: https://wiki.openttd.org/Shared_orders# Shared_Orders


This comment was imported from FlySpray: https://bugs.openttd.org/task/6181#comment13649

@DorpsGek
Copy link
Member Author

petrkalivoda wrote:

Hi. I've made a patch that allows cloning of multiple vehicles at once.
Please note that this is my first patch, so please don't be too harsh with me, any suggestions are most welcome.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6181#comment13908

@DorpsGek
Copy link
Member Author

petrkalivoda wrote:

I have normalized spacing in localisation files and uncommented some wrongly commented-out code.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6181#comment13909

@DorpsGek
Copy link
Member Author

retro wrote:

Hello Peter.

I would suggest to refactor this patch into less "hackish" one by introducing new command called "CmdMultiCloneVehicle" and calling that instead of calling CmdCloneVehicle multiple times. Check command_type.h and vehicle_cmd.cpp. You can handle CommandCost for whole operation there at once. The same stands for game item limits. It will be great to make this multiple cloning operation "transactional" and ensure it can be finished before any action is made or show error message for example with cost of whole operation.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6181#comment13910

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth closed the ticket.

Reason for closing: Won't implement

Similar to #2402, which was rejected. Cloning via ctrl-click is acceptable, adding a UI with a number to type in adds more complexity. Already cloning is hard to learn, as it can be achieved in multiple ways, with magic modifier keys that affect shared orders. Adding more complexity there is not a current goal for OpenTTD.

Flyspray clean up, so closing this. Thanks for the suggestion.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6181

@DorpsGek DorpsGek closed this as completed Sep 1, 2017
@DorpsGek DorpsGek added Clone vehicles flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant