Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject/Verb agreement in Unit Localization strings #6122

Closed
DorpsGek opened this issue Sep 25, 2014 · 1 comment
Closed

Subject/Verb agreement in Unit Localization strings #6122

DorpsGek opened this issue Sep 25, 2014 · 1 comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Supercheese opened the ticket and wrote:

In the strings for Unit Localization settings (STR_CONFIG_SETTING_LOCALISATION_UNITS_VELOCITY through STR_CONFIG_SETTING_LOCALISATION_UNITS_HEIGHT_SI), especially the HELPTEXT strings, there are some issues with singular/plural subject/verb agreement. To wit, they read:

STR_CONFIG_SETTING_LOCALISATION_UNITS_VELOCITY_HELPTEXT :Whenever a speed is shown in the user interface, show it in the selected units
STR_CONFIG_SETTING_LOCALISATION_UNITS_POWER_HELPTEXT :Whenever a vehicle's power is shown in the user interface, show it in the selected units
STR_CONFIG_SETTING_LOCALISATION_UNITS_WEIGHT_HELPTEXT :Whenever weights are shown in the user interface, show it in the selected units
STR_CONFIG_SETTING_LOCALISATION_UNITS_VOLUME_HELPTEXT :Whenever volumes are shown in the user interface, show it in the selected units
STR_CONFIG_SETTING_LOCALISATION_UNITS_FORCE_HELPTEXT :Whenever tractive effort, also known as tractive force, is shown in the user interface, show it in the selected units
STR_CONFIG_SETTING_LOCALISATION_UNITS_HEIGHT_HELPTEXT :Whenever heights are shown in the user interface, show it in the selected units

Oddly, half of the strings use plurals (weights, volumes, heights) and the other half singulars (speed, power, tractive effort) in the first clause. Despite this, all six strings use a singular in the second clause, "show it in the selected units".

I suggest that all six be unified to strictly use only singular or only plural, to eliminate the discrepancies.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6122
@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 2, 2014

Rubidium closed the ticket.

Reason for closing: Fixed

In r26947


This comment was imported from FlySpray: https://bugs.openttd.org/task/6122

@DorpsGek DorpsGek closed this as completed Oct 2, 2014
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant