Zydeco wrote:

easy steps to reproduce the crash:
- open console
- type a dead key (´ on a spanish keyboard, or option-E on UK or US keyboard)
- ´ will appear in the console, marked with a dark red background
- type backspace

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13214

kernigh2 wrote:

I can reproduce this crash on my Mac, but I haven't tried the patch yet.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13452

frosch wrote:

I guess DiscardMarkedText should be called instead of DeleteChar, but I do not know what to call in case of InsertChar resp. whether that could be called at all during the marked-state.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13455

michi_cc wrote:

According to my fake OSX 10.7 I think the attached patch might be the proper solution. It doesn't handle the delete key like in e.g. TextEditor, but it is not because OTTD wouldn't delete the accent, but because OSX sends us an explicit insertText message with the accent after the delete. No idea what other apps do different there, but then OTTD only implements the minimal subset and in no way all the functionality of the real Cocoa text GUI control.

Attachments

• fs5972.patch (2.60 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13457

kernigh2 wrote:

The patch by Michael Lutz prevents the crash on my Mac. (I run OS X 10.4.11, but with --disable-cocoa-quickdraw because of #6087.)

But this patch only works around the problem, without fixing its cause. OpenTTD handles the events in the wrong order. If I type a dead key and then backspace, the Cocoa driver in src/video/cocoa uses this order:

1. Call HandleKeypress() with the backspace. This calls Textbuf:HandleKeyPress().
2. Call HandleTextInput(NULL, true) to delete the marked text. This calls Textbuf::InsertString().
3. Call HandleTextInput(..., false, ...) to insert the completed text from the IME.

But src/textbuf.cpp expects the other order:

1. Delete the marked text.
2. Insert the completed text.
3. Handle the backspace.

This conflict between src/video/cocoa and src/textbuf.cpp happens not only with backspace, but also with the left and right arrow keys. I guess src/video/cocoa calls HandleKeypress() and HandleTextInput() in the wrong order. I don't have a patch yet, but one might reverse the order if one would pass the backspace or arrow to the IME, and respond to NSTextInput messages (setMarkedText or insertText), before passing the same backspace or arrow to HandleKeypress().

fs5972.patch also has extra code to delete a character from the marked text. This is confusing (because the marked text no longer equals the text from the IME) but also meaningless (because the Cocoa driver is about to delete the whole marked text). So I am attaching a much simpler patch, just-ignore-keys.patch, which steals the work-around idea from fs5972.patch, but without the extra code.

Attachments

• just-ignore-keys.patch (0.34 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13460

michi_cc wrote:

Simply ignoring the extra keys won't work as for example the Japanese IME relies on cursor movement.

The more or less "proper" alternative seems to be the lot longer patch attached. This implements more of the text editing API to handle what our edit box can do. Now deletion of an accent actually behaves as in TextEdit, and any IME that synthesizes cursor movement would work as well.

Attachments

• fs5972_more_complicated.patch (4.27 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13467

kernigh2 wrote:

Your patch is "complicated" but awesome! It works for me.

(I tried playing with the Mac's Japanese IME, too, but the hiragana and kanji display as question marks in OpenTTD. I might be using the wrong font or encoding.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13468

michi_cc wrote:

The default sprite font only has latin glyphs. To get a font with asian glyphs you either have to specify a font in openttd.cfg or switch the game to e.g. Japanese (and test your knowledge of OTTD's GUI :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972#comment13470

michi_cc closed the ticket.

Reason for closing: Fixed

In r26758 (if the gods are merciful).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5972