FS#5958 - [OSX] Trackpad pinch gesture support broken (r25666)

Attached to Project: OpenTTD
Opened by xmirakulix (xmirakulix) - Saturday, 29 March 2014, 13:22 GMT
Last edited by andythenorth (andythenorth) - Saturday, 02 September 2017, 11:33 GMT
Type Bug
Category Interface
Status New
Assigned To No-one
Operating System Mac OS X
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


There is a commit to trunk, that includes support for the pinching gesture on Trackpads in e.g. a Macbook:
(svn r25666) -Feature [ FS#4760 ]: [OSX] Pinch gesture support for zooming. (Based on patch by leecbaker)

Unfortunately, the functionality, as it is implemented has a flaw that renders it unusable for me:
Trackpads act as a two-way mouse wheel too, so the best setting for the mouse wheel when playing is to "scroll map", not "zoom map".
The implementation as far as I understand it though just "turns" the mouse wheel when pinching, not actually zoom.
Thus the map doesn't get zoomed then.

The commit is said to be based on FS task #4760 "pinch to zoom support" (/task/4760).
That patch in contrast to the implementation in trunk seems to define two new hotkeys that are then used to actually zoom the map, regardless of the mouse wheel setting.

This seems to be a better way to implement that feature, as the "mousewheel" (two parallel fingers) and the "pinch" gesture are two different things on the trackpad and should not be mixed.

My Setup: Macbook Air, OS X 10.9.2
This task depends upon