Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback station numbers glitches #5909

Closed
DorpsGek opened this issue Feb 15, 2014 · 2 comments
Closed

Fallback station numbers glitches #5909

DorpsGek opened this issue Feb 15, 2014 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Simons_Mith opened the ticket and wrote:

In my scratch game, the station numbers in one town, once I'd hit the naming limit, started at # 452. But, scratch game, much strangeness, inclusing mucking about the station name strings. Hence don't worry too much at present. However:

In a clean game, I picked a new town, spammed it with truck stops, used up all the names including 2-3 extras provided by FIRS, and ended up with a total of /27/ stations, of which the last few were numbered 19,20,22,23,25,26,27,28. So 21 and 24 missing, and the total station count off by /two/ (two because there were two towns close together and I accidentally placed one station in the neighboring town catchment area.

I suspect fix 26275 may not quite be doing its job; it deduplicates OK, but the interaction with FIRS station names has caused its numbering count to end up needlessly skipping some values.

To reproduce: try any NewGrf that provides additional station names, spam 1-square bus/lorry stations in a town until you start getting stations with # numbered fallback names. Join a couple of 1-square stations into 2-squares (or more) at junctions, I think that may be confusing it too.

Reported version: 1.4.0-beta4
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/5909
@DorpsGek
Copy link
Member Author

Rubidium wrote:

The numbering in the stations is simply the unique ID of the station. Once a station is removed that ID is freed and can be reused. This numbering has nothing to do with NewGRFs, though... depending on the circumstances a particular station name can be used in one location when it can't be in another. For example East/West/North/South, Valley/Heights, Woods, Mines, Lakeside, Central all have specific preconditions on where they can be built. Due to that it's easily possible that the 22nd station (the one with ID 21) would have gotten a particular name. Furthermore, that 22nd station can also be the one in the "wrong" town.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5909#comment13062

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Not a bug


This comment was imported from FlySpray: https://bugs.openttd.org/task/5909

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant