OpenTTD

Tasklist

FS#5902 - Switching cargodist settings causes funnies

Attached to Project: OpenTTD
Opened by Simon Smith (Simons_Mith) - Tuesday, 11 February 2014, 01:01 GMT
Last edited by fonsinchen (fonsinchen) - Sunday, 16 February 2014, 16:29 GMT
Type Bug
Category Core
Status Closed
Assigned To fonsinchen (fonsinchen)
Operating System All
Severity Low
Priority Normal
Reported Version Version?
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

As an example, my scratch game was on asymmetric distribution for the 'other' caro type. I changed that to 'manual'. This caused all the old cargo destination information to disappear. But I speculate that some of the old cargo still hanging about could still remember where it wanted to go, becuase it refused to go anywhere else! I wouldn't mind, /if/ that information was still visible until you've cleared out the old stuff, although perhaps better (exploitable, though) would be to just clear the destination information it if you switch modes.
This task depends upon

Closed by  fonsinchen (fonsinchen)
Sunday, 16 February 2014, 16:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r26341
Comment by fonsinchen (fonsinchen) - Tuesday, 11 February 2014, 22:59 GMT
Can you please attach a savegame showing that the cargo doesn't go "anywhere else" after switching off cargodist? The destination information is supposed to get cleared.
Comment by Simon Smith (Simons_Mith) - Wednesday, 12 February 2014, 00:09 GMT
Train 47 is about to come out the depot. It will load to about 85%, leaving about 660,000 gallons of chemicals waiting - ample to fill it up completely, if only it would take it. That 660,000 gallons has been sitting there for a long time. The oil trains roughly keep the chemical trains ticking over, but there's enough spare chemical transport capacity that they should have begun to make inroads on that 660k by now. As it is I keep getting trains going back to the depot and stopping because they can't/won't fill themselves up past 90%.

I think the trains are only collecting the new chemicals/petrol that's produced, and not any of the old stuff that's been sitting around. I think it was originally destined for a rarely-visited or removed-from-the-timetable-entirely station.

Note, I've just saved this from build 26318M - but the only modifications are to some of the text strings I've playing about with - see the forum threads. I hope that hasn't interfered. Getting a clean saved-game that hasn't been touched by my recent experimental builds may take a while.
Comment by fonsinchen (fonsinchen) - Saturday, 15 February 2014, 12:27 GMT
https://github.com/ulfhermann/openttd/commit/ceecad269cf1acab4717aaed03ebd430ef4cf19f fixes it. Note that you still have to wait until the link graph is calculated the next time after switching distribution to manual. With your settings ("Update distribution graph every 16 days") that will take significant time. I recommend resetting this to the default of 4, or even 2 if you have a fast computer or only simple link graphs.

Loading...