Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced _do_autosave? #5871

Closed
DorpsGek opened this issue Jan 23, 2014 · 1 comment
Closed

Misplaced _do_autosave? #5871

DorpsGek opened this issue Jan 23, 2014 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

MJP opened the ticket and wrote:

I believe _do_autosave is set to false 1 line too early.

1/ Definition:
bool _do_autosave; ///< are we doing an autosave at the moment?

2/ In openttd.cpp, GameLoop():
if (_do_autosave) {
_do_autosave = false;
DoAutosave();

3/ DoAutosave() calls SaveOrLoad()

4/ In saveload.cpp, SaveOrLoad() tests a value always false:
/* if not an autosave, but a user action, show error message */
if (!_do_autosave) ShowErrorMessage(STR_ERROR_SAVE_STILL_IN_PROGRESS, INVALID_STRING_ID, WL_ERROR);

Attachments

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5871
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 9, 2014

Rubidium closed the ticket.

Reason for closing: Fixed

In r26326. Thanks for the patch


This comment was imported from FlySpray: https://bugs.openttd.org/task/5871

@DorpsGek DorpsGek closed this as completed Feb 9, 2014
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant