Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failure in command.cpp when converting sections of rail #5866

Closed
DorpsGek opened this issue Jan 14, 2014 · 7 comments
Closed

Assertion failure in command.cpp when converting sections of rail #5866

DorpsGek opened this issue Jan 14, 2014 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

efess opened the ticket and wrote:

OS: Windows 7 N

Assertion failure while converting rail from one type to another. This happened while using the NUTS trainset - converting red purr to green purr. I've seen this crash with nutracks as well.

This save uses GRFs from bananas and the openttd-coop pack (http://wiki.openttdcoop.org/GRF)

Reproducible - load the original save, change rail type to Green purr, convert the rail in the same manner as in the screenshot.

Reported version: 1.4.0-beta2
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/5866
@DorpsGek
Copy link
Member Author

Alberth wrote:

What save are you talking about?
That wiki page only discusses the grf pack, no NUTS, no screenshot, no mentioning of Purr, no converting of tracks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12922

@DorpsGek
Copy link
Member Author

efess wrote:

Sorry, not sure why the files didn't attach. Trying again. One of the attachments is "Original.sav" which is the save state before the crash.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12924

@DorpsGek
Copy link
Member Author

adf88 wrote:

I found the bug and fixed it. In CmdConvertRail there is a check: "If both ends of tunnel/bridge are in the range, do not try to convert twice it would cause assert because of different test and exec runs" (http://vcs.openttd.org/svn/browser/trunk/src/rail_cmd.cpp?rev=26262# L1640). But that check is always orthogonal (never diagonal).

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12925

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2014

efess wrote:

Tested against 26275 - this patch fixes the issue.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12993

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2014

fonsinchen wrote:

I think we should add a DiagonalTileArea implementation at this point. Rumour has it that there is such a thing somewhere. If anyone can supply me with a patch I will happily review it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12996

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2014

efess wrote:

-deleted- ..refreshing posts the comment again. Noted.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866#comment12997

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 2, 2014

fonsinchen closed the ticket.

Reason for closing: Fixed

In r26291

This comment was imported from FlySpray: https://bugs.openttd.org/task/5866

@DorpsGek DorpsGek closed this as completed Feb 2, 2014
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek