Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refitting at a station should also work if vehicles have already reserved cargo #5839

Closed
DorpsGek opened this issue Dec 28, 2013 · 5 comments
Closed

Refitting at a station should also work if vehicles have already reserved cargo #5839

DorpsGek opened this issue Dec 28, 2013 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

fonsinchen opened the ticket and wrote:

If you give a transfer-refit-full load order the refit won't be carried out because the full load makes the vehicle reserve cargo before refitting. Thus the vehicle is not "empty" when it tries to refit. Instead the vehicle should return its reserved cargo and carry out the refit. See https://github.com/ulfhermann/openttd/commits/refit for a possible solution.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5839
@DorpsGek
Copy link
Member Author

andythenorth wrote:

Articulated vehicles have problems - as per http://bugs.openttd.org/task/4953# comment10689

'Tastyworth Transport' save game demonstrates this using a single truck from eGRVTs 2 (on Bananas) - refit orders aren't respected at Tastyworth Mines, iron ore cargo is reload to vehicle.

Additionally I earlier managed to trigger an assert whilst testing similar orders in a different game. Crashlog looks like it's related to cargo counts, but I could be wrong. Testing that save would need multiple unreleased grfs from me...let me know if you want them ;)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5839#comment12867

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Articulated vehicles have problems - as per http://bugs.openttd.org/task/4953# comment10689

'Tastyworth Transport' save game demonstrates this using a single truck from eGRVTs 2 (on Bananas) - refit orders aren't respected at Tastyworth Mines, iron ore cargo is reload to vehicle.

Additionally I earlier managed to trigger an assert whilst testing similar orders in a different game. Crashlog looks like it's related to cargo counts, but I could be wrong. Testing that save would need multiple unreleased grfs from me...let me know if you want them ;)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5839#comment12869

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

The load/unload conflict created by articulated vehicles in case of refit is not supposed to be solved by the patch. The patch only deals with the conflict between reservation and refit - that's somewhat related but not entirely the same. I'll have a look at the crashlog, though.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5839#comment12872

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

The assert is probably because of this oversight of mine: ulfhermann/openttd@f768bf9

This comment was imported from FlySpray: https://bugs.openttd.org/task/5839#comment12873

@DorpsGek
Copy link
Member Author

fonsinchen closed the ticket.

Reason for closing: Fixed

In r26187

This comment was imported from FlySpray: https://bugs.openttd.org/task/5839

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek