FS#5776 - Autoreplace: better feedback for failed force-upgrade in depot

Attached to Project: OpenTTD
Opened by Jørn Lomax (jvlomax) - Friday, 04 October 2013, 10:01 GMT
Last edited by andythenorth (andythenorth) - Friday, 01 September 2017, 07:51 GMT
Type Feature Request
Category Vehicles → Autoreplace
Status Assigned
Assigned To andythenorth (andythenorth)
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


A window will try to snap to a window that is not visible.

To reproduce: Set a wagon or train to autoreplace with another. Send trains to depot and press "Autoreplace all trains in depot" without having enough money to do so. No error is thrown, nothing happens
If I hold shift while pressing the button, it will give me an estimated cost

Expected behaviour: The game should tell me I don't have Enough Money

Actual behaviour: The action fails and the game does not tell me why

System info:
Windows 7
Openttd r25797 (downloaded precompiled binary)
This task depends upon

Comment by Alberth (Alberth) - Saturday, 05 October 2013, 18:44 GMT
Enable the vehicle news
Comment by Jørn Lomax (jvlomax) - Saturday, 05 October 2013, 18:49 GMT
I know it shows in the news section, it's also in the news log. But I still think a red error message window should pop up explaining why it doesn't work.
Comment by Alberth (Alberth) - Sunday, 06 October 2013, 08:41 GMT
Yeah nice, every time an autoreplace fails throw an error message at the user.
Ever wondered what would happen if you do that when attempting (and failing) with 500+ trains running around?

I agree it could be more visible, but simply throwing an error message on failure is not the solution, I think.
Comment by andythenorth (andythenorth) - Thursday, 17 August 2017, 07:47 GMT
The OP is suggesting this only triggers a message when the depot 'force upgrade' button is used. It took me literally years to learn what that button does, as most of the time, pressing it causes nothing to happen. A message specific to pressing that button does seem like a fair improvement to me. :)