Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSGoal::GoalType GT_StoryPage #5761

Closed
DorpsGek opened this issue Sep 23, 2013 · 6 comments
Closed

GSGoal::GoalType GT_StoryPage #5761

DorpsGek opened this issue Sep 23, 2013 · 6 comments
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

idioty opened the ticket and wrote:

example: GSGoal.New(GSCompany::CompanyID company, Text * goal, GT_StoryPage, uint32 storypage_id);
This solution useful if the goal state or goal details text is very long.
If I click on this goal, show the Story Page (if available).
If the company == GSCompany::COMPANY_INVALID, then show the global StoryPage page.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5761
@DorpsGek
Copy link
Member Author

Zuu wrote:

Attached patch adds GT_STORY_PAGE.

Both the goal and the story page must have the same company visibility in this patch. It could be changed though so that a company goal could still refer to a global page.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761#comment12775

@DorpsGek
Copy link
Member Author

idioty wrote:

Thx!

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761#comment12776

@DorpsGek
Copy link
Member Author

Zuu wrote:

Updated patch:
- Fix: Don't relocate view when clicking on story goal
- Change: Relax story page company condition. Allow a company goal to refer to a global story page.
- Codechange: break long line into several lines (would otherwise be ~600 chars long)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761#comment12781

@DorpsGek
Copy link
Member Author

idioty wrote:

I can not build with these patch, because I have a same problem: http://bugs.openttd.org/task/5797

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761#comment12783

@DorpsGek
Copy link
Member Author

Zuu closed the ticket.

Reason for closing: Implemented

In r26012

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761

@DorpsGek
Copy link
Member Author

idioty wrote:

It works well for me on the r26014 version. Both global and company's StoryPage.
Thanks again!

This comment was imported from FlySpray: https://bugs.openttd.org/task/5761#comment12788

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Goal/Game script labels Apr 7, 2018
@frosch123 frosch123 added the component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) label Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DorpsGek @frosch123