Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI: add info about clipping and integer overflow to AICompany::GetBankBalance #5634

Closed
DorpsGek opened this issue Jul 6, 2013 · 4 comments
Closed
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 6, 2013

Kogut opened the ticket and wrote:

based on http://www.tt-forums.net/viewtopic.php?f=65&t=63754

a) "Returns: The actual bank balance. " is incorrect - it return bank balance, clipped to integer size in Squirrel (intsize = 2147483647)

b) It may be nice to mention that it is likely source of integer overflows

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5634
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 6, 2013

Kogut wrote:

ops. "intsize = 2147483647" is wrong, intsize is 4 what implies 2147483647 as maxint in 32 bit architecture


This comment was imported from FlySpray: https://bugs.openttd.org/task/5634#comment12384

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 6, 2013

krinn wrote:

Agree to that too. When resolved, this one could be close too http://bugs.openttd.org/task/5410


This comment was imported from FlySpray: https://bugs.openttd.org/task/5634#comment12385

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth wrote:

Is this resolved by r26585? https://git.openttd.org/?p=trunk.git;a=commit;h=ebe3c797dce90e5265a81389d8babbb1d0a999ac


This comment was imported from FlySpray: https://bugs.openttd.org/task/5634#comment14706

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth closed the ticket.

Reason for closing: Implemented

Believed fixed by r26585? https://git.openttd.org/?p=trunk.git;a=commit;h=ebe3c797dce90e5265a81389d8babbb1d0a999ac

Flyspray clean up, closing. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5634

@DorpsGek DorpsGek closed this as completed Sep 1, 2017
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant