Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple hotkey actions bound to the same key #5619

Closed
DorpsGek opened this issue Jun 26, 2013 · 2 comments
Closed

Multiple hotkey actions bound to the same key #5619

DorpsGek opened this issue Jun 26, 2013 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

3298 opened the ticket and wrote:

This patch allows binding more than one action to a single key. I originally intended it to be a part of the transparency window patch I posted on the forums to fix a limitation in that patch, but of course the hotkey changes work on their own, too.
The hotkey patch I posted in the transparency patch thread has been split into four parts:

  1. Codechange: HotkeyList::CheckMatch can continue a hotkey search now
  2. Codechange: Differentiate between normal and tool-activating hotkeys
  3. Codechange: Prohibit a tool hotkey from being processed if another tool hotkey was processed on the same keypress
  4. Feature(ish): Allow multiple hotkey actions assigned to one key if at most one of them is a tool hotkey

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5619
@DorpsGek
Copy link
Member Author

3298 wrote:

Known minor issue: Some hotkey defaults in current trunk are conflicting and would lead to two or three unrelated actions at the same time if this patch is used. These are:
D: skip order, activate dynamite in landscaping toolbar
F: delete order, focus sign list filter box, focus script break-on-log filter box
Number keys: activate infrastructure building tools, switch to companies in script debug window
C: center viewport on cursor, toggle matching case in script debug window
Return: open chat, continue paused script
Zuu just told me on the forum that some of these hotkeys are only available if the script developer tools are turned on.

The obvious solution is to change the defaults, but that might lead to questions like "Why doesn't work anymore?"

This comment was imported from FlySpray: https://bugs.openttd.org/task/5619#comment12620

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

_3298: looking back, 5619 is more like a solution in search of a problem
andythenorth: wondered about that
_3298: i wrote it to get around a design flaw in my transparency gui draft, then solved it in another way, and dumped the patch on the bugtracker for others to find
andythenorth: _3298: mind if I close it?
_3298: it's mostly useless

This comment was imported from FlySpray: https://bugs.openttd.org/task/5619

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek