Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only first engine in consist gets date_of_last_service updated #5550

Closed
DorpsGek opened this issue May 14, 2013 · 4 comments
Closed

only first engine in consist gets date_of_last_service updated #5550

DorpsGek opened this issue May 14, 2013 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

R25214

[17:46:03] when a train comes into depot, only the first engine gets date_of_last_service updated.
[17:46:55] when a consist is split into vehicles, the other engines have date_of_last_service not updated
[17:47:13] equal to day of build

All the engines in consist should have the date of service updated.

Why is it important.
When all the trains should change a livery after a certain date, it looks very silly when they do a change on the fly (on a speed on over 100km/h). So I decided to change current date check to date of last service. Unfortunately it works only for the front engines, but not the other.
It is possible to check the date of the first engine, but when the train is split into parts (to assemble several smaller trains from one large train), the engines become magically transformed into old one. It looks stupid, because it was updated together with the old front engine.
To fix it the date_of_last_service should be updated for all the engines in consist.
In case date_of_last_service is stored for wagons, it should be updated for them too.

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/5550
@DorpsGek
Copy link
Member Author

George wrote:

same in r25239


This comment was imported from FlySpray: https://bugs.openttd.org/task/5550#comment12215

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Untested yet, this patch services every vehicle in a consist, given that the first is being serviced.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5550#comment12220

@DorpsGek
Copy link
Member Author

frosch wrote:

I guess it should not do that for the aircraft parts. GetEngine will likely return non-sense or crash.

Wrt. the other hunk :p I guess "private" fits better than "hidden".


This comment was imported from FlySpray: https://bugs.openttd.org/task/5550#comment12221

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r25604


This comment was imported from FlySpray: https://bugs.openttd.org/task/5550

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant