sbr wrote:

-Change: move new methods inside private scope of BuildObjectWindow.
-Fix: clear unsigned-signed comparison warning.
-Fix: compare spec index with SpecCount not with UiSpecCount.
-Fix: tests if an object is selected before trying to make it visible.

Please find attached these three patches against r25087.

Attachments

• 00ensure-object-class-visibility.patch (1.29 KiB)
• 01restore-selected-object-index.patch (1.42 KiB)
• 02ensure-selected-object-visibility.patch (0.68 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503#comment12089

Alberth wrote:

Suggestion: also restore the width of the matrix?
(Drag the object window so the matrix has several columns, select the 'bomb' to delete an object, re-select the object window, and you're back to a single column of objects.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503#comment12183

sbr wrote:

I have an old unpublished patch that restore the size of BuildRailStationWindow (by storing the count of rows/columns of the matrix).
I'll update it and also adapt it to the BuildObjectWindow; these two windows could benefit from this functionality.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503#comment12189

sbr wrote:

The first three patches are bumped to r25246.
The fourth patch restore the previous size of the BuildObjectWindow. The window dimension aren't stored in pixels. It's the number of row of the classes list and the number of columns of the types matrix that are stored. This allow to recompute the size of the window by taking in account the font size.

Please find attached these four patches against r25246.

Attachments

• 00ensure-object-class-visibility_r25246.patch (1.41 KiB)
• 01restore-selected-object-index_r25246.patch (1.54 KiB)
• 02ensure-selected-object-visibility_r25246.patch (0.80 KiB)
• 03restore-window-size_r25246.patch (3.46 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503#comment12222

Alberth wrote:

Thrown in trunk r25281-r25284

- Fixed some bits in the Doxygen comments,
- 01 had a space behind the cast, and the "<" of the object test should be "<=" (counts are one bigger than the largest index),
- 03 was simplified a lot, and added prevention in reducing the window in size (if one dimension was larger but the other one was smaller).

thanks for the patches. Eye-candy players will like it a lot.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503#comment12236

Alberth closed the ticket.

Reason for closing: Implemented

This comment was imported from FlySpray: https://bugs.openttd.org/task/5503