Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aircraft get stuck with a high acceleration value #5492

Closed
DorpsGek opened this issue Mar 1, 2013 · 5 comments
Closed

Aircraft get stuck with a high acceleration value #5492

DorpsGek opened this issue Mar 1, 2013 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 1, 2013

Pikka opened the ticket and wrote:

If property 0D of an aircraft is set too high (dec. 20 or higher, in my test), the aircraft will get stuck with 0 speed when attempting to leave the hangar. Presumably an overflow in the acceleration calculation?

Test grf with acceleration property set to dec. 40 can be found here: https://www.tt-forums.net/viewtopic.php?f=26&t=64394&p=1068439# p1068439

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5492
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 1, 2013

Pikka wrote:

even single-digit acceleration values are very fast (the highest value I use in av8 is 2!), so clamping this property to the maximum value that doesn't break would be an acceptable fix IMO.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5492#comment12065

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 1, 2013

Pikka wrote:

(actually, supersonic aircraft like the Concorde have it set to 8. same diff.).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5492#comment12066

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r25099

This comment was imported from FlySpray: https://bugs.openttd.org/task/5492

@DorpsGek
Copy link
Member Author

frosch wrote:

Actually, NewGRF aircraft acceleration was off by factor 8/3 (5/3 too fast) in OTTD since r8973, while default aircraft were off 16/77 (5 times too slow).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5492#comment12099

@DorpsGek
Copy link
Member Author

frosch wrote:

The acceleration behaviour was fixed in r25115. The property and default aircraft now accelerate again as intended.
Also the property can again use values up to 255.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5492#comment12107

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek