Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a space in this string #5447

Closed
DorpsGek opened this issue Jan 23, 2013 · 4 comments
Closed

Add a space in this string #5447

DorpsGek opened this issue Jan 23, 2013 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Evropi opened the ticket and wrote:

There should be a space between 'None' and '{STRING}' in the string 'STR_VEHICLE_INFO_NO_CAPACITY'.

It currently reads:

{BLACK}Capacity: {LTBLUE}None{STRING}

Wherein {STRING} returns the cargo subtype.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5447
@DorpsGek
Copy link
Member Author

Supercheese wrote:

I hacked together a reeeeally quick and dirty grf that demonstrates why there should be a space. Steps to reproduce:

  1. Load attached grf, start a game at earliest 1930.

  2. Build a train depot

  3. Build a "police car" in the train depot (as I said, quick and hacky)

  4. Click the police car's vehicle information button

  5. Click the "capacities" tab

Observe the capacity shows as "None(Siren On)". It should have a space, to make it "None (Siren On)".

I've also observed the other strings immediately below STR_VEHICLE_INFO_NO_CAPACITY in the language file do not have a space in them, such as STR_VEHICLE_INFO_CAPACITY. Other strings, however, do have a space, such as the refit menu strings.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5447#comment11898

@DorpsGek
Copy link
Member Author

frosch wrote:

This is normal behaviour for subtypes.
Subtypes always appear right after the cargo, no matter whether it is "None" or a real cargo.

While this may be stupid, it is the historically defined behaviour of TTDPatch and all existing GRF have spaces in front of their subtypes.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5447#comment11902

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Not a bug

intentional behaviour


This comment was imported from FlySpray: https://bugs.openttd.org/task/5447

@DorpsGek
Copy link
Member Author

frosch wrote:

The inconsistency with the refit GUI was fixed in r24938.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5447#comment11904

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant