Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle var 4C not affected by bridge speed limits #5397

Closed
DorpsGek opened this issue Dec 19, 2012 · 2 comments
Closed

Vehicle var 4C not affected by bridge speed limits #5397

DorpsGek opened this issue Dec 19, 2012 · 2 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Pikka opened the ticket and wrote:

r24825

I am updating UKRS2 to use vehicle var 4C, rather than var 98. I use this variable to test how close the train is to its top speed, by subtracting the var B4, current speed, from var 4C, or var 98 in the old version.

This works great and the running sounds and costs are now changed correctly when the train is slowed by a timetable, but not when the train is slowed by a bridge speed limit. It is desirable that bridge speed limits should affect this variable, but the documentation is unclear on whether it currently should ("including e.g track or timetable speed limits"). I have not yet tested speed-limited tracktypes.

When attempting to create a test grf for this issue, I crashed OpenTTD. I will post that crash separately.

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/5397
@DorpsGek
Copy link
Member Author

michi_cc wrote:

No visible difference for vehicle behaviour pre and post patch, so it should be good. And it's conceptually cleaner anyway.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5397#comment11770

@DorpsGek
Copy link
Member Author

michi_cc closed the ticket.

Reason for closing: Fixed

In r24832.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5397

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant