FS#5322 - -Fix (r21961): no unloading indicator if order is 'no unloading' and 'no loading'.

Attached to Project: OpenTTD
Opened by S├ębastien Brissaud (sbr) - Sunday, 07 October 2012, 16:44 GMT
Last edited by Ingo von Borstel (planetmaker) - Tuesday, 09 October 2012, 19:11 GMT
Type Patch
Category Interface
Status Closed
Assigned To No-one
Operating System All
Severity Very Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When a vehicle stay at a station and its order is "No unloading and no loading", the unloading indicator (down arrow) is shown next to its cargo count percentage.

Prior to r21961 (-Remove: limitation that not loading and not unloading is mutual exclusive) this order state wasn't available and the code that select the loading indicator didn't test that case.

I think that when a vehicle stay at a station with a "No unloading and no loading" order only its cargo count percentage should be shown.

Please find attached a patch against r24575.
This task depends upon

Closed by  Ingo von Borstel (planetmaker)
Tuesday, 09 October 2012, 19:11 GMT
Reason for closing:  Implemented
Additional comments about closing:  In r24579. Thanks for the patch